Skip to content

Fix invalid cursor in assignable users#8705

Merged
alexr00 merged 1 commit intomainfrom
alexr00/then-cockroach
Apr 27, 2026
Merged

Fix invalid cursor in assignable users#8705
alexr00 merged 1 commit intomainfrom
alexr00/then-cockroach

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Apr 27, 2026

Co-authored-by: Copilot copilot@github.com

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 27, 2026 12:37
@alexr00 alexr00 enabled auto-merge (squash) April 27, 2026 12:37
@alexr00 alexr00 self-assigned this Apr 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes pagination failures when fetching assignable users by ensuring cursor compatibility across GraphQL query fallbacks in GitHubRepository.getAssignableUsers.

Changes:

  • Track when the code falls back from suggestedActors to the legacy assignableUsers query and keep using the legacy query for subsequent pages.
  • Update result typing/null handling around repository access to avoid assuming non-null data.
Show a summary per file
File Description
src/github/githubRepository.ts Keeps pagination on the legacy assignableUsers query after a fallback to prevent “invalid cursor” errors when mixing cursor sources.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread src/github/githubRepository.ts
Comment thread src/github/githubRepository.ts
@alexr00 alexr00 marked this pull request as draft April 27, 2026 12:44
auto-merge was automatically disabled April 27, 2026 12:44

Pull request was converted to draft

@alexr00 alexr00 marked this pull request as ready for review April 27, 2026 12:56
@alexr00 alexr00 enabled auto-merge (squash) April 27, 2026 12:56
@alexr00 alexr00 merged commit c3a2cf7 into main Apr 27, 2026
10 checks passed
@alexr00 alexr00 deleted the alexr00/then-cockroach branch April 27, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants