Skip to content

Fix diagnostics for debugging tests#14311

Merged
luabud merged 3 commits intomicrosoft:mainfrom
luabud:FixMessageForDebuggingTests
Nov 3, 2020
Merged

Fix diagnostics for debugging tests#14311
luabud merged 3 commits intomicrosoft:mainfrom
luabud:FixMessageForDebuggingTests

Conversation

@luabud
Copy link
Copy Markdown
Member

@luabud luabud commented Oct 7, 2020

For #14067

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

@luabud luabud added the no-changelog No news entry required label Oct 7, 2020
@luabud luabud requested review from karrtikr and kimadeline October 21, 2020 21:11
@luabud luabud force-pushed the FixMessageForDebuggingTests branch from 58591d5 to 8e3d1a1 Compare October 29, 2020 22:08
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 29, 2020

Codecov Report

Merging #14311 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14311      +/-   ##
==========================================
- Coverage   64.91%   64.90%   -0.01%     
==========================================
  Files         541      541              
  Lines       25131    25131              
  Branches     3544     3544              
==========================================
- Hits        16313    16312       -1     
- Misses       8155     8156       +1     
  Partials      663      663              
Impacted Files Coverage Δ
.../client/testing/common/managers/baseTestManager.ts 45.13% <ø> (ø)
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0dad5...8e3d1a1. Read the comment docs.

@luabud luabud merged commit a678fbe into microsoft:main Nov 3, 2020
ericsnowcurrently pushed a commit that referenced this pull request Feb 19, 2021
fixes #14866

In #14311 we worked around a bug in a way that caused the strange message reported in #14866 (pytest with debugger). This change fixes that one without regressing the previous fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants