Fix the "Problem" messages for pytest failures when debugging.#15434
Conversation
kimadeline
left a comment
There was a problem hiding this comment.
The fix looks good to me. Is there a reason why we need verbose explanations for it in comments?
karrtikr
left a comment
There was a problem hiding this comment.
Please update existing tests if any. LGTM otherwise.
|
Did you check that your new changes are not re-introducing #14067? |
That was resolved with the changes in #15387. Test results with an Also, I have manually verified that debugging tests (under pytest) does not fail (as in #14067) and no longer generates any entries in the "Problems" panel, whereas before (due to #14311) each test had an entry with the "Ok". So the cause of #14067 no longer exists and #14866 is fixed. |
Codecov Report
@@ Coverage Diff @@
## main #15434 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 561 561
Lines 26924 26954 +30
Branches 3901 3911 +10
======================================
+ Hits 17521 17531 +10
- Misses 8679 8695 +16
- Partials 724 728 +4
|
fixes #14866
In #14311 we worked around a bug in a way that caused the strange message reported in #14866 (pytest with debugger). This change fixes that one without regressing the previous fix.