Added unit tests for client/linters/pylint.ts #6879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
changed the title
karrtikr
changed the title
DonJayamanne
approved these changes
Aug 12, 2019
kimadeline
suggested changes
Aug 12, 2019
kimadeline
left a comment
kimadeline
left a comment
There was a problem hiding this comment.
Mostly some tidbits here and there (nothing too serious)
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-Authored-By: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
karrtikr
commented
Aug 13, 2019
kimadeline
reviewed
Aug 13, 2019
karrtikr
commented
Aug 13, 2019
kimadeline
reviewed
Aug 13, 2019
kimadeline
reviewed
Aug 13, 2019
kimadeline
reviewed
Aug 13, 2019
kimadeline
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6117