Skip to content

Added unit tests for client/linters/pylint.ts #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 16 commits into from
Aug 14, 2019
Merged

Added unit tests for client/linters/pylint.ts #6879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
128d379
Added tests
Aug 7, 2019
d0b49d5
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
b105d0d
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
64bf845
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
3587efd
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
cf44248
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
dcba223
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
d8e2c6d
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
4734d6f
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
0fe1b4f
Code reviews
Aug 13, 2019
0d7f9cc
Make folder platform independent
Aug 13, 2019
189a074
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
3890101
Update src/test/linters/pylint.unit.test.ts
Aug 13, 2019
82e3f02
Fix DRY
Aug 13, 2019
a69dc72
Oops
Aug 13, 2019
16057d8
Skip tests
Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/linters/pylint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class Pylint extends BaseLinter {
];
const messages = await this.run(minArgs.concat(args), document, cancellation, REGEX);
messages.forEach(msg => {
msg.severity = this.parseMessagesSeverity(msg.type, this.pythonSettings.linting.pylintCategorySeverity);
msg.severity = this.parseMessagesSeverity(msg.type, settings.linting.pylintCategorySeverity);
});

return messages;
Expand Down
4 changes: 2 additions & 2 deletions src/test/application/diagnostics/applicationDiagnostics.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ suite('Application Diagnostics - ApplicationDiagnostics', () => {
const oldValueOfVSC_PYTHON_CI_TEST = process.env.VSC_PYTHON_CI_TEST;

setup(() => {
process.env.VSC_PYTHON_UNIT_TEST = undefined;
process.env.VSC_PYTHON_CI_TEST = undefined;
delete process.env.VSC_PYTHON_UNIT_TEST;
delete process.env.VSC_PYTHON_CI_TEST;
serviceContainer = typemoq.Mock.ofType<IServiceContainer>();
envHealthCheck = typemoq.Mock.ofType<IDiagnosticsService>();
envHealthCheck.setup(service => service.runInBackground).returns(() => true);
Expand Down
Loading