Issue
The verbiage for Lock Group and Unlock Group in the Editor Menu is confusing. I must have missed it in the Release Notes when this feature was released, so I wasn't aware of what the feature did. After trying a few things to see if it was what I thought it was, I had to resort to searching for the answer online to find out what meant. When I found out what this feature actually does, I was surprised.
Being short doesn't always mean concise, but being concise means that it is as short as it can be. This is an example of that.
What it could mean
- Prevent files from being closed in this group (by either click or hotkey)
- Prevent files from being dragged from another group to this group
- Prevent files from being arranged in this group
- Prevent this group's editor from being resized
Surely there are more things that it could mean. It is so ambiguous that I decided to open this issue because I certainly cannot be the only one confused.
Proposal
Replace Lock Group with clearer verbiage, something along the lines of Prevent opening new files here or Don't open new files in this group or Lock files from opening here. There may be something with fewer words, as long as it is clear what the feature does.
Whatever verbiage is chosen for Lock Group, the Unlock Group should inversely match.
Lock Group
|
MenuRegistry.appendMenuItem(MenuId.EmptyEditorGroupContext, { command: { id: TOGGLE_LOCK_GROUP_COMMAND_ID, title: localize('toggleLockGroup', "Lock Group"), toggled: ActiveEditorGroupLockedContext }, group: '3_lock', order: 10, when: MultipleEditorGroupsContext }); |
|
MenuRegistry.appendMenuItem(MenuId.EditorTitle, { command: { id: TOGGLE_LOCK_GROUP_COMMAND_ID, title: localize('lockGroup', "Lock Group"), toggled: ActiveEditorGroupLockedContext }, group: '8_lock', order: 10, when: MultipleEditorGroupsContext }); |
Unlock Group
|
MenuRegistry.appendMenuItem(MenuId.EmptyEditorGroup, { command: { id: UNLOCK_GROUP_COMMAND_ID, title: localize('unlockGroupAction', "Unlock Group"), icon: Codicon.lock }, group: 'navigation', order: 10, when: ActiveEditorGroupLockedContext }); |
|
title: localize('unlockEditorGroup', "Unlock Group"), |
Issue
The verbiage for Lock Group and Unlock Group in the Editor Menu is confusing. I must have missed it in the Release Notes when this feature was released, so I wasn't aware of what the feature did. After trying a few things to see if it was what I thought it was, I had to resort to searching for the answer online to find out what meant. When I found out what this feature actually does, I was surprised.
Being short doesn't always mean concise, but being concise means that it is as short as it can be. This is an example of that.
What it could mean
Surely there are more things that it could mean. It is so ambiguous that I decided to open this issue because I certainly cannot be the only one confused.
Proposal
Replace Lock Group with clearer verbiage, something along the lines of Prevent opening new files here or Don't open new files in this group or Lock files from opening here. There may be something with fewer words, as long as it is clear what the feature does.
Whatever verbiage is chosen for Lock Group, the Unlock Group should inversely match.
Lock Group
vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts
Line 326 in fd5fbb5
vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts
Line 352 in fd5fbb5
Unlock Group
vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts
Line 318 in fd5fbb5
vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts
Line 493 in fd5fbb5