`Git Bash` doesn't work with `Git for widows SDK` out of the box

[brice-gros]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.76.2
• OS Version: Win11 22H2 (OS Build 22621.1344)

Steps to Reproduce:

1. install Git for Windows SDK (without Git for Windows installed)
2. Open VSCode with "terminal.integrated.defaultProfile.windows": "Git Bash" in vscode settings.json
3. Open the vscode Terminal
4. PowerShell opens (not Git Bash which is not listed either)

Potential fix:

Inside getGitBashPaths(), add some of these options:

• Add the default installation c:\\git-sdk-64\\usr\\bin\\bash.exe as a special path
• Add ${gitDir}\\usr\\bin\\bash.exe when pushing to gitBashPaths, so if c:\\git-sdk-64\\usr\\bin is in the PATH, findExecutable('git.exe') will add c:\\git-sdk-64 as a gitDirs, and c:\\git-sdk-64\\usr\\bin\\bash.exe will be pushed into gitBashPaths

Known workaround:

Create a link C:/Program Files/Git pointing to C:/git-sdk-64

# from git bash
# Assuming user with `SeCreateSymbolicLinkPrivilege` privilege (always true for admin users) and `export MSYS="winsymlinks:nativestrict $MSYS"` called in git bash
ln -s /c/git-sdk-64 /c/Program\ Files/Git
# or use NTFS Links
mklink /D "C:\Program Files\Git" "C:\git-sdk-64"

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[Tyriar]

We check git.exe's path in the upcoming version so this should be fixed:

https://github.com/babakks/vscode/blob/f280df4ed87d477bf6cd69fa53af2f884348043c/src/vs/platform/terminal/node/terminalProfiles.ts#L280-L286

[brice-gros]

@Tyriar I don't think it will
With Git for Windows SDK (NOT the standard Git for Windows), assuming git.exe is in the path, here is what this will give:

const gitExePath = await findExecutable('git.exe');  //==> c:\\git-sdk-64\\usr\\bin\\git.exe
if (gitExePath) {
    const gitExeDir = dirname(gitExePath);           //==> c:\\git-sdk-64\\usr\\bin
    gitDirs.add(resolve(gitExeDir, '../..'));        //==> c:\\git-sdk-64
    console.log('gitDirs', gitDirs);
}
function addTruthy<T>(set: Set<T>, value: T | undefined): void {
    if (value) {
	    set.add(value);
    }
}

// Add common git install locations
addTruthy(gitDirs, process.env['ProgramW6432']);
addTruthy(gitDirs, process.env['ProgramFiles']);
addTruthy(gitDirs, process.env['ProgramFiles(X86)']);
addTruthy(gitDirs, `${process.env['LocalAppData']}\\Program`);

const gitBashPaths: string[] = [];
for (const gitDir of gitDirs) {
    gitBashPaths.push(
	    `${gitDir}\\Git\\bin\\bash.exe`,         //==> c:\\git-sdk-64\\Git\\bin\\bash.exe
	    `${gitDir}\\Git\\usr\\bin\\bash.exe`     //==> c:\\git-sdk-64\\Git\\usr\\bin\\bash.exe
    );
}

// Add special installs that don't follow the standard directory structure
gitBashPaths.push(`${process.env['UserProfile']}\\scoop\\apps\\git-with-openssh\\current\\bin\\bash.exe`);

return gitBashPaths;
}

In the end, gitBashPaths does NOT contain c:\\git-sdk-64\\usr\\bin\\bash.exe