Skip to content

Disable api-version-check for now#300495

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/fierce-hawk
Mar 10, 2026
Merged

Disable api-version-check for now#300495
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/fierce-hawk

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Mar 10, 2026

Needed to unblock #300477

cc @alexr00

Copilot AI review requested due to automatic review settings March 10, 2026 17:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily disables the “API Proposal Version Check” GitHub Actions workflow job to unblock PR workflows related to #300477.

Changes:

  • Disables the check-version-changes job by setting if: false.
  • Leaves the previous conditional logic in comments for later re-enablement.

Comment on lines +26 to +30
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting if: false skips the job entirely (conclusion becomes “skipped/neutral”), which won’t satisfy branch protection if this workflow/job is configured as a required check. If the goal is to unblock merges while disabling the enforcement, consider keeping the job running and exiting successfully with a short no-op step, or adjust branch protection/required checks in tandem with this change.

Suggested change
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
if: github.event_name == 'pull_request' ||
(github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(github.event.comment.body, '/api-proposal-change-required'))

Copilot uses AI. Check for mistakes.
Comment on lines +26 to +30
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out original condition is currently indented under the if: false line, which reads a bit like a YAML continuation. For readability, consider dedenting these comments to the same level as if: (or moving them above) so it’s clear they’re just reference comments and not part of the YAML structure.

Suggested change
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
if: false # temporarily disabled

Copilot uses AI. Check for mistakes.
@mjbvz mjbvz merged commit 2eefd9e into microsoft:main Mar 10, 2026
22 checks passed
alexr00 added a commit that referenced this pull request Mar 11, 2026
alexr00 added a commit that referenced this pull request Mar 11, 2026
* Revert "Merge pull request #300495 from mjbvz/dev/mjbvz/fierce-hawk"

This reverts commit 2eefd9e, reversing
changes made to 34bfd71.

* Add lots of logging

* Update .github/workflows/api-proposal-version-check.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants