Disable api-version-check for now#300495
Conversation
Needed to unblock microsoft#300477
There was a problem hiding this comment.
Pull request overview
Temporarily disables the “API Proposal Version Check” GitHub Actions workflow job to unblock PR workflows related to #300477.
Changes:
- Disables the
check-version-changesjob by settingif: false. - Leaves the previous conditional logic in comments for later re-enablement.
| if: false # temporarily disabled | ||
| # github.event_name == 'pull_request' || | ||
| # (github.event_name == 'issue_comment' && | ||
| # github.event.issue.pull_request && | ||
| # contains(github.event.comment.body, '/api-proposal-change-required')) |
There was a problem hiding this comment.
Setting if: false skips the job entirely (conclusion becomes “skipped/neutral”), which won’t satisfy branch protection if this workflow/job is configured as a required check. If the goal is to unblock merges while disabling the enforcement, consider keeping the job running and exiting successfully with a short no-op step, or adjust branch protection/required checks in tandem with this change.
| if: false # temporarily disabled | |
| # github.event_name == 'pull_request' || | |
| # (github.event_name == 'issue_comment' && | |
| # github.event.issue.pull_request && | |
| # contains(github.event.comment.body, '/api-proposal-change-required')) | |
| if: github.event_name == 'pull_request' || | |
| (github.event_name == 'issue_comment' && | |
| github.event.issue.pull_request && | |
| contains(github.event.comment.body, '/api-proposal-change-required')) |
| if: false # temporarily disabled | ||
| # github.event_name == 'pull_request' || | ||
| # (github.event_name == 'issue_comment' && | ||
| # github.event.issue.pull_request && | ||
| # contains(github.event.comment.body, '/api-proposal-change-required')) |
There was a problem hiding this comment.
The commented-out original condition is currently indented under the if: false line, which reads a bit like a YAML continuation. For readability, consider dedenting these comments to the same level as if: (or moving them above) so it’s clear they’re just reference comments and not part of the YAML structure.
| if: false # temporarily disabled | |
| # github.event_name == 'pull_request' || | |
| # (github.event_name == 'issue_comment' && | |
| # github.event.issue.pull_request && | |
| # contains(github.event.comment.body, '/api-proposal-change-required')) | |
| # github.event_name == 'pull_request' || | |
| # (github.event_name == 'issue_comment' && | |
| # github.event.issue.pull_request && | |
| # contains(github.event.comment.body, '/api-proposal-change-required')) | |
| if: false # temporarily disabled |
* Revert "Merge pull request #300495 from mjbvz/dev/mjbvz/fierce-hawk" This reverts commit 2eefd9e, reversing changes made to 34bfd71. * Add lots of logging * Update .github/workflows/api-proposal-version-check.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Needed to unblock #300477
cc @alexr00