Settings links in Release Notes do nothing - #268455
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes settings links in release notes by adding support for the code-setting protocol and enabling proper rendering of settings references.
- Adds
Schemas.codeSettingto allowed link protocols for security sanitization - Augments allowed HTML tags and attributes to support SVG icons in settings links
- Adds comprehensive test coverage for settings link rendering functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| releaseNotesEditor.ts | Updates markdown sanitizer to allow code-setting protocol and SVG elements for settings links |
| releaseNotesRenderer.test.ts | Adds new test case with mock preferences service to verify settings rendering |
| Release_notes_renderer_Should_render_code_settings.0.snap | Test snapshot showing expected HTML output for rendered settings links |
| Release_notes_renderer_Should_render_TOC.0.snap | Updated snapshot with proper nav tag formatting |
| getSetting: (id: string) => { | ||
| if (id === testSettingId) { | ||
| // Provide the minimal fields accessed by SimpleSettingRenderer | ||
| return <any>{ |
There was a problem hiding this comment.
Replace <any> cast with a proper type or interface that matches the expected return type for getSetting method.
…rer.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
lszomoru
approved these changes
Sep 30, 2025
joaomoreno
approved these changes
Sep 30, 2025
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #268443