Skip to content

Revert "Put terminal voice actions in separate group (#269596)"#270085

Merged
meganrogge merged 2 commits intomainfrom
merogge/revert
Oct 6, 2025
Merged

Revert "Put terminal voice actions in separate group (#269596)"#270085
meganrogge merged 2 commits intomainfrom
merogge/revert

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge commented Oct 6, 2025

This reverts commit 77a9703.

They were in the navigation group intentionally

Copilot AI review requested due to automatic review settings October 6, 2025 18:45
@meganrogge meganrogge self-assigned this Oct 6, 2025
@meganrogge meganrogge added this to the October 2025 milestone Oct 6, 2025
@meganrogge meganrogge enabled auto-merge (squash) October 6, 2025 18:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that moved terminal voice actions (Start/Stop Dictation) into a separate "voice" menu group. The revert restores the original organization where these actions are grouped with other navigation items.

  • Removes the dedicated "voice" menu group for terminal voice actions
  • Moves Start/Stop Dictation actions back to the "navigation" group in the terminal view title
  • Removes unused imports that were introduced for the separate voice group

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/terminalContrib/voice/browser/terminalVoiceActions.ts Removes menu configuration and unused imports from voice action registrations
src/vs/workbench/contrib/terminal/browser/terminalMenus.ts Adds back Start/Stop Dictation menu items to the navigation group

@meganrogge meganrogge merged commit eb8570f into main Oct 6, 2025
28 checks passed
@meganrogge meganrogge deleted the merogge/revert branch October 6, 2025 20:30
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants