Put terminal voice actions in separate group#269596
Merged
meganrogge merged 3 commits intomainfrom Oct 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Separates terminal voice (dictation) actions into their own menu group rather than mixing them with general navigation actions in the terminal view title. Voice start/stop actions are now registered alongside their action definitions instead of globally in terminalMenus.
- Moved Start/Stop Dictation menu contributions from terminalMenus.ts into terminalVoiceActions.ts
- Introduced new menu group 'voice' for terminal dictation actions
- Removed old menu entries from the generic terminal menus
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/voice/browser/terminalVoiceActions.ts | Adds menu contributions for start/stop dictation actions in a new 'voice' group |
| src/vs/workbench/contrib/terminal/browser/terminalMenus.ts | Removes previous dictation menu items from the generic terminal view title menu |
…lVoiceActions.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
meganrogge
commented
Oct 2, 2025
joshspicer
approved these changes
Oct 2, 2025
meganrogge
added a commit
that referenced
this pull request
Oct 6, 2025
This reverts commit 77a9703.
meganrogge
added a commit
that referenced
this pull request
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #269587