Explore a controller based chat session item API #286642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
force-pushed
the
dev/mjbvz/chat-session-item-controller
branch
from
442306f to
e337681
Compare
For #276243 Explores moving the chat session item api to use a controller instead of a provider
mjbvz
force-pushed
the
dev/mjbvz/chat-session-item-controller
branch
from
e337681 to
3f197a6
Compare
bpasero
reviewed
Jan 13, 2026
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
I have no objections going with this API considering we have a similar one that seems finalised. But I am also not deep into providing sessions via API, so I would yield to @joshspicer and maybe @DonJayamanne and @osortega for final approval.
Contributor
|
I'll try this out later today. |
DonJayamanne
approved these changes
Jan 13, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
…-controller Explore a controller based chat session item API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #276243
Explores moving the chat session item api to use a controller instead of a provider. This uses managed objects and is based on the
TestControllerwe already have finalizedMain flow :
Extensions call
createChatSessionItemController('my.sessionId')to create the controller. The controller is a managed object with adisposemethodVS Code then calls
refreshHandleron the controller to build up the initial listDuring refresh, the extension updates the
ChatSessionItemCollectionmanaged object. This object is basically just a managed array. This lets the editor see changes that are made to the session listA few other points:
Chat session items would now also be managed objects. Extensions could set properties to update them in the UI
If an extension needs to update the list of chat session items independently of VS Code — for example if a new session is created through GitHub.com — it would simply update the
ChatSessionItemCollectionWe would have event handlers for when the editor archives or disposes of a chat session item
Still some open questions but seems promising. Also although the general API shape looks pretty different , the logic shouldn't be that different for extensions