Skip to content

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 14, 2026

Fixes #278567

Resubmission of #278858

Copilot AI review requested due to automatic review settings January 14, 2026 00:23
@vs-code-engineering
Copy link

vs-code-engineering bot commented Jan 14, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts
  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsPicker.ts
  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors chat session timing information to provide more granular tracking by replacing startTime/endTime with created, lastRequestStarted, and lastRequestEnded fields. The old fields are deprecated but maintained for backward compatibility.

Changes:

  • Updated timing API to track session creation and individual request timing separately
  • Deprecated old startTime and endTime fields in the public API
  • Added backward compatibility for reading old cached sessions and external provider data

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vscode.proposed.chatSessionsProvider.d.ts Added new timing fields (created, lastRequestStarted, lastRequestEnded) and deprecated old fields (startTime, endTime)
chatService.ts Updated IChatSessionTiming interface with new fields and comprehensive documentation
chatModel.ts Updated timing getter to compute new timing fields from request data
chatSessionStore.ts Updated session metadata to use new timing structure
chatSessionsService.ts Changed to use IChatSessionTiming type directly
chatServiceImpl.ts Added fallback logic for old data migration
agentSessionsModel.ts Updated model to handle new timing fields with backward compatibility for cached sessions
extHostChatSessions.ts Added backward compatibility layer to convert old API usage to new format
agentSessionsViewer.ts Updated viewer to use new timing fields with proper fallback chain
agentSessionsPicker.ts Updated picker to use new timing fields
localAgentSessionsProvider.test.ts Updated tests with new timing structure and helper function
agentSessionsDataSource.test.ts Updated tests to use new timing fields
agentSessionViewModel.test.ts Updated tests with new timing structure

DonJayamanne
DonJayamanne previously approved these changes Jan 14, 2026
@mjbvz mjbvz enabled auto-merge January 14, 2026 01:12
@mjbvz mjbvz merged commit 81f7af4 into microsoft:main Jan 14, 2026
17 checks passed
alexr00 added a commit that referenced this pull request Jan 14, 2026
…row"

This reverts commit 81f7af4, reversing
changes made to 85a14f9.
alexr00 added a commit that referenced this pull request Jan 14, 2026
* Revert "Merge pull request #287668 from mjbvz/dev/mjbvz/eventual-sparrow"

This reverts commit 81f7af4, reversing
changes made to 85a14f9.

* Revert "Merge pull request #286642 from microsoft/dev/mjbvz/chat-session-item-controller"

This reverts commit b39ecc3, reversing
changes made to 45aced5.
eli-w-king pushed a commit that referenced this pull request Jan 14, 2026
eli-w-king pushed a commit that referenced this pull request Jan 14, 2026
* Revert "Merge pull request #287668 from mjbvz/dev/mjbvz/eventual-sparrow"

This reverts commit 81f7af4, reversing
changes made to 85a14f9.

* Revert "Merge pull request #286642 from microsoft/dev/mjbvz/chat-session-item-controller"

This reverts commit b39ecc3, reversing
changes made to 45aced5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent sessions: provide inProgressTime and finishedOrFailedTime from provider

2 participants