Adding sandbox pre-reqs to the setting UI for linux #291380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the terminal sandbox settings description for Linux to clarify required dependencies for the sandboxed terminal tool. It ensures that users are informed about necessary binaries when configuring the Linux sandbox filesystem access.
Changes:
- Updated the
TerminalSandboxLinuxFileSystemsetting’smarkdownDescriptionto mention that bubblewrap, socat, and ripgrep need to be installed for the setting to work. - Improved structure of the description by splitting the “applicable only when enabled” note onto its own line.
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts:546
- In the markdown description, there's no space before
**bubblewrap**(".env).**bubblewrap**"), which will render awkwardly; consider adding a space so it reads".env). **bubblewrap**".
markdownDescription: localize('terminalSandbox.linuxFileSystemSetting', "Note: this setting is applicable only when {0} is enabled. Controls file system access in the terminal sandbox on Linux.Paths does not support glob patterns, only literal paths (ex: ./src/, ~/.ssh, .env).**bubblewrap**, **socat** and **ripgrep** should be installed for this setting to work.", `\`#${TerminalChatAgentToolsSettingId.TerminalSandboxEnabled}#\``),
...rkbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts
Outdated
Show resolved
Hide resolved
…/terminalChatAgentToolsConfiguration.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…91370) * chat: use ConnectionObserverElement to track template mount state Replaces the hacky 'renderedPartsMounted' boolean with a custom element that leverages the native connectedCallback and disconnectedCallback lifecycle hooks to track whether parts are mounted in the DOM. - Adds ConnectionObserverElement custom element (connection-observer) that fires onDidConnect and onDidDisconnect callbacks - Updates IChatListItemTemplate to use connectionObserver element instead of renderedPartsMounted boolean - Removes manual mount state management in disposeElement since the element's disconnectedCallback handles it automatically - Uses native element.isConnected property to check mount state Fixes #290903 (Commit message generated by Copilot) * pr comments
Co-authored-by: hediet <2931520+hediet@users.noreply.github.com>
* Fix issue with runSubagent result text It was collecting text between tool calls when it should only collect the text after the final tool calls. And edits in subagents left behind an empty codeblock in the result text. * Delete comment
…ation (#291304) * fix: update argument for using custom source in nuget package installation * fix tests
- Remove context menu for open in editor since there's a button now - Faster pinch zoom - Only pan when holding alt/option - Fix transparent button on hover
* Sanity tests updates * Revert qemu accidental change.
Feeling more confident in its current state. Let's preview this feature for stable users too
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
* smarter check for confirmation * address some comments * fix carousel question icon not showing * undo commit * undo commit 2
Fixes compatibility with pre-1.104 versions where the source property may be undefined for deserialized tool invocations. Uses optional chaining when accessing the source property to prevent errors. - Make source property optional in IChatToolInvocationSerialized interface - Use optional chaining operator when checking source.type in chat renderer - Add comment explaining the pre-1.104 compatibility requirement Ref #288489 (Commit message generated by Copilot)
Also cancel event propegation in toggles which would cause he item to be accepted when you clicked on the the toggle. Fixes #290775
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jriekenMatched files:
|
jrieken
requested changes
Jan 29, 2026
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
this PR shouldn't change the inlineChatOverlayWidget
Member
Author
yeah just saw this, seems wrong merge. Updating it. |
Member
Author
|
Incorrect merges and lot of merge conflicts, created a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:#291022
For linux, bubblewrap, socat and ripgrep should be installed. Updated the setting UI to show this