Animated show/hide transitions for workbench panels and quick input#294261
Merged
eli-w-king merged 2 commits intoeli/workbench-motionfrom Feb 11, 2026
Merged
Animated show/hide transitions for workbench panels and quick input#294261eli-w-king merged 2 commits intoeli/workbench-motionfrom
eli-w-king merged 2 commits intoeli/workbench-motionfrom
Conversation
- Filter transitionend events by e.target to ignore bubbling from descendant elements in both entrance and exit animations - Add safety timeout fallback to entrance animation (matching exit pattern) - Clear safety timeouts when animations complete or are cancelled - Reorder variable declarations for better readability Co-authored-by: eli-w-king <201316543+eli-w-king@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add side and bottom panel motion animations
Animated show/hide transitions for workbench panels and quick input
Feb 11, 2026
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds animated visibility transitions for sidebar, panel, auxiliary bar, and quick input using CSS transitions and a new
setViewVisibleAnimatedAPI on SplitView/GridView/Grid.Screen.Recording.2026-02-09.at.2.05.33.PM.mov
Motion infrastructure
src/vs/base/browser/ui/motion/motion.tsmodule: duration constants, easing curves (Fluent 2), cubic-bezier evaluation, distance-proportional duration scaling, andisMotionReduced()check that integrates with existingmonaco-reduce-motionclassSplitView.setViewVisibleAnimated(): animates between start/final sizes usingrequestAnimationFrame, with cancellation support via returnedIDisposableGridView.setChildVisibleAnimated()/Grid.setViewVisibleAnimated(): propagate animated visibility through the grid hierarchy, correctly handling the "all children hidden" edge case by deferring_onDidVisibilityChange(false)toonCompleteWorkbench layout
layout.ts:setSideBarHidden,setPanelHidden,setAuxiliaryBarHiddenuse animated path with deferred CSS class / composite hiding inonComplete; cancellation-safe via immediate state application before animation startsQuick input animations
transitionendlistener filtered bye.targetto ignore bubbling from descendants, plus safety timeout fallback_cancelExitAnimationfor rapid show/hide cycles💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.