Skip to content

Animated show/hide transitions for workbench panels and quick input #294261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eli-w-king merged 2 commits into from
Feb 11, 2026
Merged

Animated show/hide transitions for workbench panels and quick input #294261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42f2854
Initial plan
Copilot Feb 10, 2026
a650799
Fix transitionend event filtering for quick input animations
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions src/vs/platform/quickinput/browser/quickInputController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,14 +734,34 @@ export class QuickInputController extends Disposable {
void ui.container.offsetHeight;
// Now apply transition and target state
ui.container.style.transition = `opacity ${QUICK_INPUT_OPEN_DURATION}ms ${EASE_OUT}, transform ${QUICK_INPUT_OPEN_DURATION}ms ${EASE_OUT}`;
ui.container.style.willChange = 'opacity, transform';
ui.container.style.opacity = '1';
ui.container.style.transform = 'translateY(0)';
const onDone = () => {
let entranceCleanedUp = false;
const window = dom.getWindow(ui.container);
let entranceCleanupTimeout: number | undefined;
const cleanupEntranceTransition = () => {
if (entranceCleanedUp) {
return;
}
entranceCleanedUp = true;
ui.container.style.transition = '';
ui.container.style.willChange = '';
ui.container.removeEventListener('transitionend', onDone);
ui.container.removeEventListener('transitionend', onTransitionEnd);
if (entranceCleanupTimeout !== undefined) {
clearTimeout(entranceCleanupTimeout);
entranceCleanupTimeout = undefined;
}
};
ui.container.addEventListener('transitionend', onDone);
const onTransitionEnd = (e: TransitionEvent) => {
if (e.target !== ui.container) {
return; // Ignore transitions from descendant elements
}
cleanupEntranceTransition();
};
ui.container.addEventListener('transitionend', onTransitionEnd);
// Safety timeout in case transitionend doesn't fire
entranceCleanupTimeout = window.setTimeout(cleanupEntranceTransition, QUICK_INPUT_OPEN_DURATION + 50);
}
}

Expand Down Expand Up @@ -812,6 +832,8 @@ export class QuickInputController extends Disposable {
// Animate exit: fade out + slide up (faster than open)
if (!isMotionReduced(container)) {
let exitCancelled = false;
const window = dom.getWindow(container);
let exitCleanupTimeout: number | undefined;
container.style.transition = `opacity ${QUICK_INPUT_CLOSE_DURATION}ms ${EASE_IN}, transform ${QUICK_INPUT_CLOSE_DURATION}ms ${EASE_IN}`;
container.style.opacity = '0';
container.style.transform = 'translateY(-8px)';
Expand All @@ -825,20 +847,33 @@ export class QuickInputController extends Disposable {
container.style.opacity = '';
container.style.transform = '';
container.style.willChange = '';
container.removeEventListener('transitionend', onDone);
container.removeEventListener('transitionend', onTransitionEnd);
if (exitCleanupTimeout !== undefined) {
clearTimeout(exitCleanupTimeout);
exitCleanupTimeout = undefined;
}
};
const onTransitionEnd = (e: TransitionEvent) => {
if (e.target !== container) {
return; // Ignore transitions from descendant elements
}
onDone();
};
this._cancelExitAnimation = () => {
exitCancelled = true;
container.style.transition = '';
container.style.opacity = '';
container.style.transform = '';
container.style.willChange = '';
container.removeEventListener('transitionend', onDone);
container.removeEventListener('transitionend', onTransitionEnd);
if (exitCleanupTimeout !== undefined) {
clearTimeout(exitCleanupTimeout);
exitCleanupTimeout = undefined;
}
};
container.addEventListener('transitionend', onDone);
container.addEventListener('transitionend', onTransitionEnd);
// Safety timeout in case transitionend doesn't fire
const window = dom.getWindow(container);
window.setTimeout(onDone, QUICK_INPUT_CLOSE_DURATION + 50);
exitCleanupTimeout = window.setTimeout(onDone, QUICK_INPUT_CLOSE_DURATION + 50);
} else {
container.style.display = 'none';
}
Expand Down
Loading