queuing: interrupt when messages are sent during confirmation#295866
Merged
connor4312 merged 3 commits intomainfrom Feb 17, 2026
Merged
queuing: interrupt when messages are sent during confirmation#295866connor4312 merged 3 commits intomainfrom
connor4312 merged 3 commits intomainfrom
Conversation
Got this feedback from a few people that steering/queuing during a tool call confirmation should just cancel the confirmation and send the message. This does that. Also cleans up the opt-in setting I had added initially that was only partially working, now that the feature has shipped.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat request queuing behavior to allow interrupting tool call confirmations by sending a new message. When a user sends a message during a tool confirmation, the confirmation is now cancelled and the new message is sent instead. The PR also removes the experimental opt-in setting for request queuing that was only partially working, now that the feature has shipped.
Changes:
- Modified queuing logic to cancel pending tool confirmations when new messages are sent
- Removed the
chat.requestQueuing.enabledconfiguration setting and all related checks - Cleaned up duplicate/unreachable code in the request queuing flow
- Removed question carousel dismissal logic that has been replaced by the new cancellation behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts | Refactored queue handling to remove duplicate logic and always process pending requests when queuing |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Added logic to cancel requests during tool confirmation and removed old question carousel handling |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removed the experimental RequestQueueingEnabled configuration setting |
| src/vs/workbench/contrib/chat/browser/actions/chatQueueActions.ts | Removed all checks for the queueingEnabledCondition context key |
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Simplified whenNotInProgress to only check for active requests, allowing submit during tool confirmation |
benvillalobos
previously approved these changes
Feb 17, 2026
Tyriar
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got this feedback from a few people that steering/queuing during a tool call confirmation should just cancel the confirmation and send the message. This does that.
Also cleans up the opt-in setting I had added initially that was only partially working, now that the feature has shipped.