ensure rendering of questions can happen while askQuestions tool call is in flight and chat is moved#297768
Merged
meganrogge merged 2 commits intomainfrom Feb 25, 2026
Merged
ensure rendering of questions can happen while askQuestions tool call is in flight and chat is moved#297768meganrogge merged 2 commits intomainfrom
meganrogge merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #297752 where questions from the askQuestions tool call are not rendered when chat is moved from editor to panel while the tool call is in-flight. The fix addresses two root causes: the old widget caching incorrect height measurements (0px) when disconnected from the DOM, and the new widget not detecting that new content parts (like question carousels) have arrived.
Changes:
- Skip refresh when container is disconnected from DOM to avoid caching incorrect measurements
- Add response content parts length to diff identity to trigger re-renders when new parts arrive
bpasero
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297752
When chat moves from editor to panel while a tool call is in-flight, two things go wrong: the old widget measures heights as 0 because it's no longer on screen, and the new widget doesn't notice that new content (like questions) arrived because nothing told the tree it changed. The fix skips the bad measurement and makes the tree aware of new content.
Repro'd every time:
#askQuestionsfrom welcome viewmove.mov