Revert "ensure rendering of questions can happen while askQuestions tool call is in flight and chat is moved"#297801
Merged
meganrogge merged 1 commit intomainfrom Feb 25, 2026
Conversation
…ool call…" This reverts commit 1c3c7c4.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #297768, which attempted to fix an issue where question carousels from the askQuestions tool wouldn't render properly when the chat widget was moved while the tool call was in flight. The original fix introduced two changes: (1) a DOM connection check to prevent refresh operations when the container is disconnected, and (2) tracking response parts length to trigger re-renders when new content parts (like question carousels) are added. However, the original fix did not actually solve the problem, which turned out to be timing-based rather than related to DOM connection or content part tracking.
Changes:
- Removes the
isConnectedcheck that prevented refresh when the chat list widget container is disconnected from the DOM - Removes the response parts length tracking (
element.response.value.length) from the tree element ID generation logic
connor4312
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #297768
Turns out this didn't fix it - there's just a timing based repro