Center agent feedback widget header on start line#302176
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Agent Sessions “agent feedback” editor overlay widget positioning so its header is vertically centered on the start line, improving alignment in the sessions-first editor experience.
Changes:
- Updates
layout()math to center the widget header on the start line using the measured header height. - Tweaks the speech-bubble arrow’s
topoffset to match the new vertical alignment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorWidget.css | Adjusts arrow pointer vertical offset to align with the updated widget positioning. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts | Centers the overlay widget’s header on the start line by using measured header height in layout calculations. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts
Show resolved
Hide resolved
roblourens
approved these changes
Mar 16, 2026
Collaborator
|
@benibenj I am moving this to 1.113 since it is targeting main. Please bring it in as a candidate if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the vertical positioning of the agent feedback editor widget so the center of the header aligns with the center of the start line, instead of placing the widget top one full line above.
Changes
agentFeedbackEditorWidgetContribution.ts— Updatedlayout()positioning math:getTopForLineNumber(startLineNumber) - lineHeight(shifted widget up by one line)getTopForLineNumber(startLineNumber) + (lineHeight - headerHeight) / 2(centers the header on the line)_headerNode.offsetHeightfor accuracyagentFeedbackEditorWidget.css— Adjusted the arrow pointertopfrom12px→9pxto match the updated header alignment.