Skip to content

Center agent feedback widget header on start line #302176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benibenj merged 2 commits into from
Mar 17, 2026
Merged

Center agent feedback widget header on start line #302176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e636de9
Align agent feedback widget header with start line center for improve…
benibenj Mar 16, 2026
085c1b9
Adjust arrow position in agent feedback widget for improved alignment
benibenj Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,10 @@ export class AgentFeedbackEditorWidget extends Disposable implements IOverlayWid

const widgetWidth = getTotalWidth(this._domNode) || 280;
const widgetHeight = this._domNode.offsetHeight || 0;
const headerHeight = this._headerNode.offsetHeight || lineHeight;

// Compute content-relative top and clamp to keep the widget within the editor content area
const contentRelativeTop = this._editor.getTopForLineNumber(startLineNumber) - lineHeight;
// Align the header center with the start line center before clamping within the editor content area.
const contentRelativeTop = this._editor.getTopForLineNumber(startLineNumber) + (lineHeight - headerHeight) / 2;
const scrollHeight = this._editor.getScrollHeight();
const clampedContentTop = Math.min(Math.max(0, contentRelativeTop), Math.max(0, scrollHeight - widgetHeight));

Expand Down
2 changes: 1 addition & 1 deletion src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorWidget.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
.agent-feedback-widget-arrow {
position: absolute;
left: -8px;
top: 12px;
top: 9px;
width: 0;
height: 0;
border-top: 8px solid transparent;
Expand Down
Loading