Layer notifications above modal editor backdrop#302749
Conversation
Notifications (toasts and center) had z-index: 1000 which is below the modal editor backdrop at z-index: 2540, making them hard to read when a modal was open. Raised to 2545 so they appear above the modal backdrop but below quick input (2550) and dialogs (2575). Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
|
@copilot is this still below hovers? thats the thing we cannot be on top of |
Yes, notifications at 2545 are still below hovers. Hovers render via The full layering order is:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI layering issue where notification toasts and the notifications center were being rendered behind the modal editor backdrop, making them difficult to see while a modal editor is open.
Changes:
- Increased
.notifications-toastsz-indexto2545so toasts render above the modal editor backdrop (2540). - Increased
.notifications-centerz-indexto2545for the same reason, keeping it below quick input (2550) and dialogs (2575).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css | Raises toast container z-index so notifications remain visible when a modal editor is open. |
| src/vs/workbench/browser/parts/notifications/media/notificationsCenter.css | Raises notification center z-index to match toast behavior and avoid being dimmed/hidden by the modal backdrop. |
Notification toasts and the notification center (
z-index: 1000) render behind the modal editor backdrop (z-index: 2540), making them nearly invisible when a modal is open.Raised both
.notifications-toastsand.notifications-centertoz-index: 2545— above the modal backdrop (2540), below quick input (2550) and dialogs (2575).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.