Skip to content

Layer notifications above modal editor backdrop#302749

Merged
bpasero merged 2 commits intomainfrom
copilot/fix-notifications-in-modal
Mar 18, 2026
Merged

Layer notifications above modal editor backdrop#302749
bpasero merged 2 commits intomainfrom
copilot/fix-notifications-in-modal

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Notification toasts and the notification center (z-index: 1000) render behind the modal editor backdrop (z-index: 2540), making them nearly invisible when a modal is open.

Raised both .notifications-toasts and .notifications-center to z-index: 2545 — above the modal backdrop (2540), below quick input (2550) and dialogs (2575).


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Notifications (toasts and center) had z-index: 1000 which is below the
modal editor backdrop at z-index: 2540, making them hard to read when a
modal was open. Raised to 2545 so they appear above the modal backdrop
but below quick input (2550) and dialogs (2575).

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix notifications readability in modal Layer notifications above modal editor backdrop Mar 18, 2026
Copilot AI requested a review from bpasero March 18, 2026 10:27
@bpasero
Copy link
Member

bpasero commented Mar 18, 2026

@copilot is this still below hovers? thats the thing we cannot be on top of

Copy link
Contributor Author

Copilot AI commented Mar 18, 2026

@copilot is this still below hovers? thats the thing we cannot be on top of

Yes, notifications at 2545 are still below hovers. Hovers render via ContextView.show() which sets z-index: 2575 + layer (see contextview.ts:194), and HoverContextViewDelegate always sets layer = stackDepth starting at 1, so hovers get z-index 2576+.

The full layering order is:

  • Modal editor backdrop: 2540
  • Notifications: 2545 (this PR)
  • Quick input: 2550
  • Dialogs: 2575
  • Hovers/context views: 2576+

@bpasero bpasero marked this pull request as ready for review March 18, 2026 11:26
Copilot AI review requested due to automatic review settings March 18, 2026 11:26
@bpasero bpasero enabled auto-merge (squash) March 18, 2026 11:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a UI layering issue where notification toasts and the notifications center were being rendered behind the modal editor backdrop, making them difficult to see while a modal editor is open.

Changes:

  • Increased .notifications-toasts z-index to 2545 so toasts render above the modal editor backdrop (2540).
  • Increased .notifications-center z-index to 2545 for the same reason, keeping it below quick input (2550) and dialogs (2575).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css Raises toast container z-index so notifications remain visible when a modal editor is open.
src/vs/workbench/browser/parts/notifications/media/notificationsCenter.css Raises notification center z-index to match toast behavior and avoid being dimmed/hidden by the modal backdrop.

@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 18, 2026
@bpasero bpasero merged commit 4f23fab into main Mar 18, 2026
25 checks passed
@bpasero bpasero deleted the copilot/fix-notifications-in-modal branch March 18, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nitpick: notifications are hard to read while in modal

4 participants