Fix/305961 create file keeps running - #305967
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Pasero (@bpasero)Matched files:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the “New File” flow so that when a filename is already provided programmatically (e.g. from the welcome “New File…” quick pick), it no longer opens a save dialog, and it also tweaks the Agent Sessions title bar label styling.
Changes:
- Update
workbench.action.files.newFileto directly use the providedargs.fileNametarget URI instead of showing a save dialog. - Adjust Sessions title bar label typography by applying a medium font weight.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/files/browser/fileCommands.ts |
Skips the save dialog when args.fileName is provided and uses the computed default URI directly. |
src/vs/sessions/contrib/sessions/browser/media/sessionsTitleBarWidget.css |
Makes the sessions title label slightly heavier (font-weight: 500). |
…ing new file flow
abfadf5 to
85130b6
Compare
|
I cleaned this PR to keep scope focused on #305961 only.\n\n- Rebased branch on latest main\n- Removed unrelated workflow/chat changes\n- Kept only the new-file command fix in src/vs/workbench/contrib/files/browser/fileCommands.ts\n\nRegarding the merge snippet in chatListRenderer: the correct resolved line is the main-side condition using isSystemInitiatedRequest, and this PR no longer carries that unrelated change. |
|
Addressed the review thread for #305961 in the current PR diff:\n\n- Validated provided fileName before using it to build the target URI\n- Rejected unsafe values by requiring the resolved URI to stay under the default file path\n- Prevented silent overwrite when fileName is provided programmatically by warning and returning if the target already exists\n- Kept overwrite behavior only for the save-dialog path\n\nThis is now in the current branch diff for src/vs/workbench/contrib/files/browser/fileCommands.ts. |
No description provided.