chat: remove providerApi.enabled setting and Claude harness from core#308590
Merged
joshspicer merged 1 commit intomainfrom Apr 8, 2026
Merged
chat: remove providerApi.enabled setting and Claude harness from core#308590joshspicer merged 1 commit intomainfrom
joshspicer merged 1 commit intomainfrom
Conversation
The provider API is now permanently enabled. This removes the chat.customizations.providerApi.enabled kill-switch setting and all associated conditional logic: - Removed CustomizationsProviderApi enum value and setting registration - Removed IConfigurationService dependency and kill-switch guards from mainThreadChatAgents2 (config listener + registration gate) - Simplified core CustomizationHarnessService to always register only the Local harness (no conditional CLI/Claude fallback) - Removed Claude harness enum value, factory, and user-root helper from common customizationHarnessService (now extension-contributed) - Removed Claude harness fixture and imports - Updated harness selector setting description (removed harness names)
joshspicer
force-pushed
the
copilot/cleanup-provider-api-setting
branch
from
f0a8f21 to
b0e02cb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the chat.customizations.providerApi.enabled kill-switch and the built-in Claude customization harness from VS Code core, making the provider API path permanently available while keeping the legacy/core discovery logic intact as a fallback.
Changes:
- Removed the
chat.customizations.providerApi.enabledconfiguration key (schema + enum) and its corresponding guard logic in the main thread. - Removed Claude harness support from the shared harness utilities and from the component fixture coverage.
- Simplified the core harness service to only statically register the Local (VS Code) harness.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts | Removes Claude harness descriptor and fixture scenario from the component fixtures. |
| src/vs/workbench/contrib/chat/common/customizationHarnessService.ts | Removes Claude harness enum value and descriptor/root helpers; updates restricted-harness docs. |
| src/vs/workbench/contrib/chat/common/constants.ts | Removes ChatConfiguration.CustomizationsProviderApi enum value. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removes configuration registration for the provider API kill-switch; updates harness-selector setting description. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/customizationHarnessService.ts | Removes conditional harness registration; always registers only the Local harness in core. |
| src/vs/workbench/api/browser/mainThreadChatAgents2.ts | Removes configuration dependency + kill-switch listener and the registration guard for customization providers. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Removed (2)
|
osortega
approved these changes
Apr 8, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal cleanup that removes the
chat.customizations.providerApi.enabledkill-switch setting and the built-in Claude harness from core VS Code. The provider API is now permanently enabled.Re-attempt of the non-breaking parts of #308341 (reverted in #308448). The core discovery path (
fetchCoreItemsForSection) and all its grouping/filtering logic are preserved — only the kill-switch and Claude harness are removed. Further cleanup will be done in follow-up PRs.What changed (6 files, +7 / -119 lines)
constants.tsCustomizationsProviderApienum valuechat.contribution.tsmainThreadChatAgents2.tsIConfigurationServicedep, kill-switch config listener, and provider registration guardcommon/customizationHarnessService.tsClaudeenum value,getClaudeUserRoots(),createClaudeHarnessDescriptor()browser/customizationHarnessService.tsaiCustomizationManagementEditor.fixture.tsWhat was NOT changed
fetchCoreItemsForSection,filterItemsForCore,applyBuiltinGroupKeys) — preservedValidation