chat: unify customization item paths via PromptsServiceCustomizationProvider by joshspicer · Pull Request #308618 · microsoft/vscode

joshspicer · 2026-04-08T21:44:11Z

Summary

Extracts the ~300-line fetchCoreItemsForSection from the AI Customizations list widget into a new PromptsServiceCustomizationProvider class that implements IExternalCustomizationItemProvider. The widget now uses a single provider-based code path for all harnesses — static (Local, CLI) and extension-contributed.

Follows #308590 which removed the kill-switch setting and Claude harness.

What changed (6 files, +406 / -509 lines)

File	Change
`promptsServiceCustomizationProvider.ts`	NEW — Provider class wrapping `IPromptsService`. Emits `IExternalCustomizationItem[]` with semantic `groupKey` (`agent-instructions`, `context-instructions`, `on-demand-instructions`, `agents`, `BUILTIN_STORAGE`), `badge`/`badgeTooltip` for applyTo patterns, `enabled: false` for disabled items
`aiCustomizationListWidget.ts`	Deleted `fetchCoreItemsForSection` (~300 lines), `filterItemsForCore` (~40), `applyBuiltinGroupKeys` (~25), `storageToIcon`, `isBuiltin`/`extensionLabel` fields, `if/else` branching in `filterItems()`. Simplified hover tooltips and copy actions. Cleaned up unused imports
`browser/customizationHarnessService.ts`	Core VS Code harness creates `PromptsServiceCustomizationProvider` and spreads `itemProvider` onto Local descriptor
`sessions/.../customizationHarnessService.ts`	Sessions CLI harness does the same
`common/customizationHarnessService.ts`	`CustomizationHarnessServiceBase` now extends `Disposable` for lifecycle management
`customizationHarnessService.test.ts`	Wrapped base class in `store.add()`

Widget size reduction

~2250 lines → ~1770 lines (-480 lines). The deleted code was the complete "core discovery path" that only the Local harness used. It's now handled by the provider class (~340 lines) which emits items in the same format as extension-contributed providers.

Verification

TypeScript compilation clean
All 15 customizationHarnessService unit tests pass
Pre-commit hygiene hooks pass

github-actions · 2026-04-08T21:47:29Z

Screenshot Changes

Base: 9588b708 Current: d1d8c121

Changed (24)

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Dark

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light

Before	After

Copilot

Pull request overview

This PR refactors the Chat Customizations management UI to use a single provider-based item loading path by extracting the legacy “core discovery” logic into a new PromptsServiceCustomizationProvider that wraps IPromptsService. This reduces complexity in the list widget and aligns Local/CLI harnesses with extension-contributed harness behavior.

Changes:

Added PromptsServiceCustomizationProvider implementing IExternalCustomizationItemProvider to emit customization items from IPromptsService.
Updated core (workbench) and sessions harness services to attach the new provider to their static harness descriptors.
Simplified AICustomizationListWidget by removing the legacy core-fetch/filter pipeline and always using the provider-based path.

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/browser/aiCustomization/promptsServiceCustomizationProvider.ts	New provider that produces `IExternalCustomizationItem[]` from `IPromptsService` and emits change events.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts	Removes legacy core discovery path and routes everything through provider-based loading/grouping.
src/vs/workbench/contrib/chat/browser/aiCustomization/customizationHarnessService.ts	Core harness now creates/registers the new provider and attaches it to the Local descriptor.
src/vs/sessions/contrib/chat/browser/customizationHarnessService.ts	Sessions harness now creates/registers the new provider and attaches it to the CLI descriptor.
src/vs/workbench/contrib/chat/common/customizationHarnessService.ts	`CustomizationHarnessServiceBase` now extends `Disposable` for lifecycle management.
src/vs/workbench/contrib/chat/test/common/customizationHarnessService.test.ts	Test updated to dispose the base service via `store.add()`.

Copilot's findings

Files reviewed: 6/6 changed files
Comments generated: 4

Copilot · 2026-04-08T21:51:51Z

 	}

+	/**
 	/**


There’s an extra nested doc-comment opener (/**) here, which makes the comment block look malformed and is likely accidental. Please remove the redundant /** so the JSDoc is a single well-formed block.

Suggested change

/**

Copilot · 2026-04-08T21:51:51Z

+		// --- Post-processing: storage source filter ---
+		const filteredItems = this._applyFilters(items);
+
+		return filteredItems;


The comment says this is a “Post-processing: storage source filter”, but _applyFilters currently only applies workspaceSubpaths/instructionFileFilter and never applies the harness’s storage source filter (sources + includedUserFileRoots). This is important for restricted harnesses like CLI, which should not surface user items outside the allowed roots. Please apply descriptor.getStorageSourceFilter(...) filtering (potentially per-item-type) before returning the list.

Copilot · 2026-04-08T21:51:51Z

+			result = result.filter(item => {
+				if (item.uri.scheme !== Schemas.file || !projectRoot || !item.uri.path.startsWith(projectRoot.path)) {
+					return true;
+				}
+				if (matchesWorkspaceSubpath(item.uri.path, subpaths)) {
+					return true;


Workspace-subpath filtering is using item.uri.scheme === file plus item.uri.path.startsWith(projectRoot.path). This can fail for remote/workspace URIs (e.g. vscode-remote:) and can produce false positives on path prefixes (e.g. /proj/foo vs /proj/foobar). Consider using isEqualOrParent(item.uri, projectRoot) (or an equivalent URI-aware parent check) and avoid hard-coding the scheme to file so the filter works consistently in remote workspaces too.

Copilot · 2026-04-08T21:51:52Z

 	private async fetchItemsForSection(section: AICustomizationManagementSection): Promise<IAICustomizationListItem[]> {
 		const promptType = sectionToPromptType(section);
-		const activeDescriptor = this.harnessService.getActiveDescriptor();
-
-		if (activeDescriptor.itemProvider && promptType) {
-			return this.fetchProviderItemsForSection(activeDescriptor, promptType);
-		}
-
-		return this.fetchCoreItemsForSection(promptType);
+		return this.fetchProviderItemsForSection(this.harnessService.getActiveDescriptor(), promptType);
 	}


Now that all harnesses (including Local/CLI) go through the provider-based path, items coming from PromptsService will frequently have groupKey set (built-in, instruction categories, etc.). In fetchItemsFromProvider, the current mapping skips _inferStorageAndGroup when groupKey is present, leaving storage undefined, which can break context-key when-clauses that rely on AI_CUSTOMIZATION_ITEM_STORAGE_KEY (e.g. read-only/delete/enable-disable actions). Please ensure storage is still inferred/set even when a provider supplies a custom groupKey (grouping and storage shouldn’t be mutually exclusive).

…rovider Extract fetchCoreItemsForSection from the list widget into a new PromptsServiceCustomizationProvider class that implements IExternalCustomizationItemProvider. It emits IExternalCustomizationItem[] with rich metadata (groupKey, badge, description, enabled) so the widget's single provider-based code path handles all harnesses. The Local (VSCode) and Sessions CLI harness services now create a PromptsServiceCustomizationProvider and wire it as the itemProvider on their static harness descriptors. This eliminates the if/else branching in fetchItemsForSection and filterItems, and removes ~500 lines of legacy core-path code from the widget: - fetchCoreItemsForSection (~300 lines) - filterItemsForCore (~40 lines) - applyBuiltinGroupKeys (~25 lines) - storageToIcon, findPluginUri, isBuiltin/extensionLabel fields - Unused imports (dirname, ResourceSet, applyStorageSourceFilter, etc.) CustomizationHarnessServiceBase now extends Disposable for lifecycle management of the provider's event subscriptions.

Copilot AI review requested due to automatic review settings April 8, 2026 21:44

Copilot started reviewing on behalf of joshspicer April 8, 2026 21:45 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

joshspicer force-pushed the copilot/unify-customization-provider branch from 981665a to 1aa6371 Compare April 8, 2026 22:00

joshspicer force-pushed the copilot/unify-customization-provider branch from 1aa6371 to 757195e Compare April 8, 2026 22:07

joshspicer closed this Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chat: unify customization item paths via PromptsServiceCustomizationProvider#308618

chat: unify customization item paths via PromptsServiceCustomizationProvider#308618
joshspicer wants to merge 1 commit intomainfrom
copilot/unify-customization-provider

joshspicer commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

               	}
+              	/**
               	/**

Conversation

joshspicer commented Apr 8, 2026

Summary

What changed (6 files, +406 / -509 lines)

Widget size reduction

Verification

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshot Changes

Changed (24)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 8, 2026 •

edited

Loading