Update copilotCLI hint setting#309866
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the terminal initial hint configuration to support an experiment-controlled Copilot CLI hint and aligns the setting ID naming.
Changes:
- Renamed the Copilot CLI initial hint setting ID to
terminal.integrated.initialHintCopilotCli. - Added an
experimentfield withmode: 'auto'for the Copilot CLI hint setting.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/inlineHint/common/terminalInitialHintConfiguration.ts | Renames the Copilot CLI hint setting ID and adds experiment metadata to its configuration schema |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
| export const enum TerminalInitialHintSettingId { | ||
| Enabled = 'terminal.integrated.initialHint', | ||
| CopilotCli = 'terminal.integrated.initialHint.copilotCli', | ||
| CopilotCli = 'terminal.integrated.initialHintCopilotCli', | ||
| } |
There was a problem hiding this comment.
Renaming a public setting ID is a breaking change for existing user/workspace settings (the old key will stop applying). Consider keeping the old terminal.integrated.initialHint.copilotCli setting as a deprecated alias in the configuration schema (with a deprecation message) and migrating/bridging it to the new ID so existing configurations continue to work.
| @@ -25,6 +25,9 @@ export const terminalInitialHintConfiguration: IStringDictionary<IConfigurationP | |||
| markdownDescription: localize('terminal.integrated.initialHint.copilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), | |||
There was a problem hiding this comment.
The localization key still uses the old setting ID (terminal.integrated.initialHint.copilotCli) even though the setting ID was renamed. To keep keys discoverable and reduce confusion for future maintenance/translation updates, update the localization key to match the new setting ID (or add an explicit comment explaining why the old key is intentionally retained).
| markdownDescription: localize('terminal.integrated.initialHint.copilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), | |
| markdownDescription: localize('terminal.integrated.initialHintCopilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), |
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
cwebster-99
added
the
~release-cherry-pick
|
This PR will be automatically cherry-picked to |
vs-code-engineering
Bot
added
release-cherry-pick
Configuration changes for Copilot CLI terminal hint:
CopilotClisetting ID fromterminal.integrated.initialHint.copilotClitoterminal.integrated.initialHintCopilotClifor consistency in naming conventions and to prevent conflicts with parent settingexperimentfield withmode: 'auto'to the Copilot CLI initial hint configuration, enabling it to be managed as an experimental feature.