Fix localization key to match renamed setting ID#309909
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the localization key for the terminal initial hint setting so it matches the renamed setting ID that was changed in #309866.
Changes:
- Renamed the
localize(...)key used for the Copilot CLI initial hint setting description.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/inlineHint/common/terminalInitialHintConfiguration.ts | Adjusts the localization key used by the Copilot CLI initial hint configuration to align with the renamed setting ID. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
| [TerminalInitialHintSettingId.CopilotCli]: { | ||
| restricted: true, | ||
| markdownDescription: localize('terminal.integrated.initialHint.copilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), | ||
| markdownDescription: localize('terminal.integrated.initialHintCopilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), |
There was a problem hiding this comment.
Renaming a localize(...) key typically invalidates existing translations because translation memory is keyed off this identifier. If the message text is unchanged, consider keeping the previous localization key (terminal.integrated.initialHint.copilotCli) to preserve existing translations, and only change the setting ID separately. If the key must change for consistency, ensure the corresponding localization resources/extraction pipeline will pick up the new key so this string doesn’t regress to English in localized builds.
| markdownDescription: localize('terminal.integrated.initialHintCopilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), | |
| markdownDescription: localize('terminal.integrated.initialHint.copilotCli', "When enabled, the terminal initial hint will suggest using Copilot CLI by typing {0} instead of opening Copilot Chat.", '`copilot`'), |
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
Missed localization change in #309866