fix title bar actions alignment - #310869
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
April 16, 2026 23:09
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
April 16, 2026 23:10
View session
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how “left-side” title actions are laid out to fix alignment issues, primarily by removing the special “global left actions” toolbar from pane composite parts and by reworking the Agent Sessions window grid/titlebar sizing logic.
Changes:
- Removes
globalLeftActionsMenuIdsupport fromAbstractPaneCompositePartand updates all callers accordingly. - Updates the Agent Sessions workbench grid descriptor to place the titlebar as a top row (vertical root) and clamps derived sizes to non-negative values.
- Reworks Agent Sessions titlebar sizing/alignment logic (and related CSS), including removing the custom left toggle action view item registration.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/sidebar/sidebarPart.ts | Drops the removed globalLeftActionsMenuId argument from the sidebar part base constructor call. |
| src/vs/workbench/browser/parts/panel/panelPart.ts | Drops the removed globalLeftActionsMenuId argument from the panel part base constructor call. |
| src/vs/workbench/browser/parts/paneCompositePart.ts | Removes globalLeftActionsMenuId from AbstractPaneCompositePart and deletes the left global toolbar creation block. |
| src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarPart.ts | Drops the removed globalLeftActionsMenuId argument from the auxiliary bar part base constructor call. |
| src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts | Removes the custom sidebar-toggle action view item (and its registration) from the sessions titlebar contribution. |
| src/vs/sessions/browser/workbench.ts | Changes grid descriptor to a vertical root with a top titlebar row and clamps computed heights to >= 0. |
| src/vs/sessions/browser/parts/titlebarPart.ts | Aligns titlebar-left width with sidebar width using a ResizeObserver and content-width measurements. |
| src/vs/sessions/browser/parts/sidebarPart.ts | Removes sidebar title and stops passing the left-titlebar menu as a “global left actions” menu. |
| src/vs/sessions/browser/parts/panelPart.ts | Drops the removed globalLeftActionsMenuId argument from the panel part base constructor call. |
| src/vs/sessions/browser/parts/media/titlebarpart.css | Adjusts titlebar flex alignment and removes CSS that hid the entire titlebar-left when the sidebar is visible. |
| src/vs/sessions/browser/parts/chatBarPart.ts | Drops the removed globalLeftActionsMenuId argument from the chat bar part base constructor call. |
| src/vs/sessions/browser/parts/auxiliaryBarPart.ts | Stops passing the removed “left title” menu id to the auxiliary bar part. |
| src/vs/sessions/browser/menus.ts | Removes the now-unused AuxiliaryBarTitleLeft menu id. |
Copilot's findings
- Files reviewed: 13/13 changed files
- Comments generated: 3
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Hawk Ticehurst (hawkticehurst)
approved these changes
Apr 16, 2026
roblourens
approved these changes
Apr 16, 2026
auto-merge was automatically disabled
April 17, 2026 06:30
Pull request was closed
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
April 17, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.