Remove extensions step from onboarding#311042
Merged
cwebster-99 merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the 2026 welcome onboarding flow by removing the dedicated “Extensions” step and deleting the now-unused product configuration that powered that step.
Changes:
- Removed the “Extensions” step ID and its title/subtitle mappings, and removed it from the ordered onboarding steps list.
- Deleted the onboarding extensions product configuration/type and removed the corresponding
product.jsondata. - Removed the Extensions-step UI logic and CSS styling from onboarding Variation A.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/welcomeOnboarding/common/onboardingTypes.ts | Drops the Extensions step from step IDs, labels, and the onboarding step sequence. |
| src/vs/workbench/contrib/welcomeOnboarding/browser/onboardingVariationA.ts | Removes all rendering/event handling for the Extensions step and related gallery/icon prefetch logic. |
| src/vs/workbench/contrib/welcomeOnboarding/browser/media/variationA.css | Removes styling rules specific to the Extensions step UI. |
| src/vs/base/common/product.ts | Removes the onboardingExtensions product configuration field and its associated interface. |
| product.json | Removes the onboardingExtensions configuration block from the product configuration. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
joshspicer
reviewed
Apr 17, 2026
| "description": "Keyboard mapping from Notepad++" | ||
| } | ||
| ], | ||
| "onboardingExtensions": [ |
Member
There was a problem hiding this comment.
Please also remove the corresponding JSON in microsoft/vscode-distro
Member
Author
There was a problem hiding this comment.
joshspicer
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding Flow Simplification:
OnboardingStepId,getOnboardingStepTitle,getOnboardingStepSubtitle, and theONBOARDING_STEPSarray. [1] [2] [3] [4]Configuration Cleanup:
onboardingExtensionsproperty and related extension interface (IProductOnboardingExtension) from the product configuration and type definitions, and removed the onboarding extensions list fromproduct.json. [1] [2] [3]UI and Styling Removal:
onboardingVariationA.ts. [1] [2] [3] [4] [5] [6] [7] [8]variationA.css. [1] [2]<!-- Thank you for submitting a Pull Request. Please:https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
mainbranch.-->