Always open overview from sidebar customization entrypoints#311050
Merged
joshspicer merged 2 commits intomainfrom Apr 17, 2026
Merged
Always open overview from sidebar customization entrypoints#311050joshspicer merged 2 commits intomainfrom
joshspicer merged 2 commits intomainfrom
Conversation
Follow-up to #310871: the sidebar entrypoint actions (Agents, Skills, Instructions, Hooks, MCP Servers, Plugins) still called selectSectionById after opening the editor, which deep-linked into the section instead of showing the overview. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Agents window sidebar customization entrypoints with the updated “always open overview” behavior for the AI Customizations management editor, avoiding section deep-links from sidebar actions.
Changes:
- Removed the post-open
selectSectionById(...)call so sidebar actions no longer jump to a specific section. - Dropped the now-unused
AICustomizationManagementEditorimport.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts | Ensures all sidebar customization actions open the AI Customizations editor on its overview/welcome page by removing section selection logic. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
connor4312
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #310871.
That PR updated the customizations overview view to always open the management editor's welcome/overview page rather than deep-linking into a section. However, the sidebar entrypoint actions (Agents, Skills, Instructions, Hooks, MCP Servers, Plugins) registered in
customizationsToolbar.contribution.tswere still callingeditor.selectSectionById(config.section)after opening the editor, so clicking any of them in the agents app sidebar still jumped straight to that section instead of the overview.This removes the
selectSectionByIdcall (and the now-unusedAICustomizationManagementEditorimport) so all sidebar entrypoints land on the overview page.