Always open Chat Customizations overview from sidebar#310871
Merged
joshspicer merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agents Sessions “Chat Customizations” sidebar overview so that interacting with any overview row always opens the Chat Customizations management editor overview (rather than deep-linking into a specific section).
Changes:
- Removed deep-linking behavior from overview items and always open the management editor overview.
- Simplified the editor-open helper accordingly and removed the now-unused editor import.
- Updated hover tooltip text to match the new behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts | Makes overview rows open the Chat Customizations editor overview instead of navigating to a specific section. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts:144
- The keydown handler calls the async
openOverview()without awaiting/handling the promise. Consider using an explicit fire-and-forget (void) and/or catching errors to prevent unhandled promise rejections during editor opening failures.
this._register(DOM.addDisposableListener(sectionElement, 'keydown', (e: KeyboardEvent) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
this.openOverview();
}
- Files reviewed: 1/1 changed files
- Comments generated: 1
roblourens
approved these changes
Apr 16, 2026
joshspicer
added a commit
that referenced
this pull request
Apr 17, 2026
Follow-up to #310871: the sidebar entrypoint actions (Agents, Skills, Instructions, Hooks, MCP Servers, Plugins) still called selectSectionById after opening the editor, which deep-linked into the section instead of showing the overview. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joshspicer
added a commit
that referenced
this pull request
Apr 17, 2026
Follow-up to #310871: the sidebar entrypoint actions (Agents, Skills, Instructions, Hooks, MCP Servers, Plugins) still called selectSectionById after opening the editor, which deep-linked into the section instead of showing the overview. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.