Skip to content

sessions: simplify titlebar session actions#311778

Merged
hawkticehurst merged 3 commits intomainfrom
agents/update-session-app-title-bar
Apr 22, 2026
Merged

sessions: simplify titlebar session actions#311778
hawkticehurst merged 3 commits intomainfrom
agents/update-session-app-title-bar

Conversation

@hawkticehurst
Copy link
Copy Markdown
Member

@hawkticehurst hawkticehurst commented Apr 21, 2026

Summary

Part of #310014 workstream

  • remove the titlebar separator bars and leftover spacing around the session picker and session action groups
  • remove the dot between the session title and folder/worktree metadata
  • remove the command-center "Mark as Done" button and rename the add-chat tooltip to "New Sub-Session"
Screenshot 2026-04-21 at 4 34 55 PM

Why

  • tightens the sessions titlebar so the active session controls read as a single, cleaner unit
  • matches the updated sessions UX copy for creating a sub-session

Notes

  • updated src/vs/sessions/LAYOUT.md to keep the layout spec in sync
  • ran npm run compile-check-ts-native
  • ran node --experimental-strip-types build/hygiene.ts on the changed files

Remove the remaining titlebar separators and extra spacing around the session picker and session action groups.

Also drop the command-center Mark as Done button and rename the Add Chat tooltip to New Sub-Session to better match the sub-session workflow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 21, 2026 20:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Screenshot Changes

Base: 16f1ebc9 Current: 617b6f73

Changed (4)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after
agentSessionsViewer/CompletedUnread/Dark
Before After
before after
agentSessionsViewer/CompletedUnread/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the Agent Sessions titlebar UI by removing visual separators/extra spacing, simplifying the active session label formatting, and aligning the “add chat” action copy with the sub-session workflow.

Changes:

  • Removed the Command Center “Mark as Done” action and renamed the “Add Chat” action title to “New Sub-Session”.
  • Removed the dot separator between session title and repo metadata (both in DOM and tooltip label).
  • Replaced vertical separator bars with spacing-only separation in relevant titlebar CSS, and updated the layout spec.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts Removes “Mark as Done” from Command Center and renames the plus action label.
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts Removes dot separator from computed pill label and DOM rendering.
src/vs/sessions/contrib/sessions/browser/media/sessionsTitleBarWidget.css Removes separator-bar styling/spacing next to the session picker item.
src/vs/sessions/contrib/changes/browser/media/changesTitleBarWidget.css Removes the previous spacing/separator styling between action groups.
src/vs/sessions/browser/parts/media/titlebarpart.css Replaces a separator bar with margin-based spacing between right-side action groups.
src/vs/sessions/LAYOUT.md Updates layout documentation and revision history to reflect the new titlebar UX.
Comments suppressed due to low confidence (1)

src/vs/sessions/LAYOUT.md:92

  • This section still refers to IActiveSessionService.getActiveSession()/IActiveSessionService.activeSession and IAgentSessionsService.model.onDidChangeSessions, but the current implementation of the titlebar widget uses ISessionsManagementService.activeSession and ISessionsManagementService.onDidChangeSessions. Please update these bullets to match the actual service names/APIs so the layout spec stays accurate.
- Keeps the command center focused on the session picker widget itself, without an adjacent "Mark as Done" action button
- Truncates the repository/worktree metadata with ellipsis before truncating the primary AI-generated session title when command center space is constrained
- On click, opens the `AgentSessionsPicker` quick pick to switch between sessions
- Gets the active session label from `IActiveSessionService.getActiveSession()` and the live model title from `IChatService`, falling back to "New Session" if no active session is found
- Re-renders automatically when the active session changes via `autorun` on `IActiveSessionService.activeSession`, and when session data changes via `IAgentSessionsService.model.onDidChangeSessions`

Comment thread src/vs/sessions/contrib/changes/browser/media/changesTitleBarWidget.css Outdated
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/c18ac022-43b9-4f2b-bd4c-e6a85a1ac931

Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
benvillalobos
benvillalobos previously approved these changes Apr 21, 2026
@hawkticehurst hawkticehurst merged commit f224646 into main Apr 22, 2026
26 checks passed
@hawkticehurst hawkticehurst deleted the agents/update-session-app-title-bar branch April 22, 2026 23:37
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants