Skip to content

fix(config): enable session controller by default in CLI settings#312197

Merged
DonJayamanne merged 2 commits intomainfrom
don/nearby-antlion
Apr 23, 2026
Merged

fix(config): enable session controller by default in CLI settings#312197
DonJayamanne merged 2 commits intomainfrom
don/nearby-antlion

Conversation

@DonJayamanne
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 18:54
@DonJayamanne DonJayamanne self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR flips the default for the Copilot CLI “session controller” implementation to be enabled by default, aligning the runtime default (TypeScript config registry) with the public configuration default in package.json.

Changes:

  • Enable github.copilot.chat.cli.sessionController.enabled by default (falsetrue) in both the extension’s config registry and package.json.
  • Remove the sanity test that previously validated Copilot CLI session listing via the legacy ChatSessionItemProvider path.
Show a summary per file
File Description
extensions/copilot/src/platform/configuration/common/configurationService.ts Switches the in-code default for the CLI session controller setting to true.
extensions/copilot/package.json Switches the public configuration schema default to true to match code.
extensions/copilot/src/extension/test/vscode-node/sanity.sanity-test.ts Removes the Copilot CLI session listing sanity test (legacy provider-based path).

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

@DonJayamanne DonJayamanne marked this pull request as ready for review April 23, 2026 19:09
@DonJayamanne DonJayamanne enabled auto-merge (squash) April 23, 2026 19:09
@DonJayamanne DonJayamanne merged commit 9ae42a5 into main Apr 23, 2026
30 checks passed
@DonJayamanne DonJayamanne deleted the don/nearby-antlion branch April 23, 2026 19:34
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants