Skip to content

fix(config): enable session controller by default in CLI settings #312197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 2 commits into from
Apr 23, 2026
+2 −25
Merged

fix(config): enable session controller by default in CLI settings #312197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3e6614
fix(config): enable session controller by default in CLI settings
DonJayamanne Apr 23, 2026
6cac6e6
eol
DonJayamanne Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/copilot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4685,7 +4685,7 @@
},
"github.copilot.chat.cli.sessionController.enabled": {
"type": "boolean",
"default": false,
"default": true,
"markdownDescription": "%github.copilot.config.cli.sessionController.enabled%",
"tags": [
"advanced"
Expand Down
23 changes: 0 additions & 23 deletions extensions/copilot/src/extension/test/vscode-node/sanity.sanity-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,11 @@ suite('Copilot Chat Sanity Test', function () {
let realContext: vscode.ExtensionContext;
let sandbox: sinon.SinonSandbox;
const fakeToken = CancellationToken.None;
const sessionItemProviders = new Map<string, vscode.ChatSessionItemProvider>();
// Before everything, activate the extension
suiteSetup(async function () {
sandbox = sinon.createSandbox();
sandbox.stub(vscode.commands, 'registerCommand').returns({ dispose: () => { } });
sandbox.stub(vscode.workspace, 'registerFileSystemProvider').returns({ dispose: () => { } });
sandbox.stub(vscode.chat, 'registerChatSessionItemProvider').callsFake((scheme, sessionItemProvider) => {
sessionItemProviders.set(scheme, sessionItemProvider);
return { dispose: () => { } };
});
const extension = vscode.extensions.getExtension('Github.copilot-chat');
assert.ok(extension, 'Extension is not available');
realContext = await extension.activate();
Expand Down Expand Up @@ -163,24 +158,6 @@ suite('Copilot Chat Sanity Test', function () {
});
});

test('Copilot CLI lists sessions', async function () {
assert.ok(realInstaAccessor);

await realInstaAccessor.invokeFunction(async (accessor) => {

const instaService = accessor.get(IInstantiationService);
const conversationFeature = instaService.createInstance(ConversationFeature);
try {
conversationFeature.activated = true;
const provider = sessionItemProviders.get('copilotcli');
assert.ok(provider);
await provider.provideChatSessionItems(CancellationToken.None);
} finally {
conversationFeature.activated = false;
}
});
});

test.skip('E2E Production Inline Chat Test', async function () {
assert.ok(realInstaAccessor);

Comment thread
DonJayamanne marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion extensions/copilot/src/platform/configuration/common/configurationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ export namespace ConfigKey {
export const CLIBranchSupport = defineSetting<boolean>('chat.cli.branchSupport.enabled', ConfigType.Simple, false);
export const CLIIsolationOption = defineSetting<boolean>('chat.cli.isolationOption.enabled', ConfigType.Simple, true);
export const CLIAutoCommitEnabled = defineSetting<boolean>('chat.cli.autoCommit.enabled', ConfigType.Simple, true);
export const CLISessionController = defineSetting<boolean>('chat.cli.sessionController.enabled', ConfigType.Simple, false);
export const CLISessionController = defineSetting<boolean>('chat.cli.sessionController.enabled', ConfigType.Simple, true);
export const CLIThinkingEffortEnabled = defineSetting<boolean>('chat.cli.thinkingEffort.enabled', ConfigType.Simple, true);
export const CLIRemoteEnabled = defineSetting<boolean>('chat.cli.remote.enabled', ConfigType.Simple, false);
export const CLISessionControllerForSessionsApp = defineSetting<boolean>('chat.cli.sessionControllerForSessionsApp.enabled', ConfigType.Simple, false);
Expand Down
Loading