Skip to content

Fix empty detailedOutcome in summarization failure telemetry#312552

Merged
bhavyaus merged 1 commit intomainfrom
dev/bhavyau/fix-summarization-detailedoutcome
Apr 26, 2026
Merged

Fix empty detailedOutcome in summarization failure telemetry#312552
bhavyaus merged 1 commit intomainfrom
dev/bhavyau/fix-summarization-detailedoutcome

Conversation

@bhavyaus
Copy link
Copy Markdown
Collaborator

Fall back to response.type when response.reason is undefined.

Copilot AI review requested due to automatic review settings April 25, 2026 18:48
@bhavyaus bhavyaus enabled auto-merge (squash) April 25, 2026 18:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts summarization failure telemetry so detailedOutcome is not empty when the backend response omits a reason, improving failure diagnostics for conversation summarization.

Changes:

  • Fall back to response.type when response.reason is missing for summarization failure telemetry.
Show a summary per file
File Description
extensions/copilot/src/extension/prompts/node/agent/summarizedConversationHistory.tsx Updates summarization failure telemetry to avoid empty detailedOutcome.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Fall back to response.type when response.reason is undefined so
detailedOutcome is always populated for non-success outcomes.
@bhavyaus bhavyaus force-pushed the dev/bhavyau/fix-summarization-detailedoutcome branch from 9cb85b9 to 1bc064f Compare April 25, 2026 19:01
@bhavyaus bhavyaus merged commit 0cb2f1d into main Apr 26, 2026
54 of 56 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/fix-summarization-detailedoutcome branch April 26, 2026 00:00
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants