Skip to content

Fix empty detailedOutcome in summarization failure telemetry #312552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhavyaus merged 1 commit into from
Apr 26, 2026
+2 −2
Merged

Fix empty detailedOutcome in summarization failure telemetry #312552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/copilot/src/extension/prompts/node/agent/summarizedConversationHistory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,8 @@ class ConversationHistorySummarizer {
private async handleSummarizationResponse(response: ChatResponse, mode: SummaryMode, elapsedTime: number, promptTypes?: string): Promise<FetchSuccess<string>> {
if (response.type !== ChatFetchResponseType.Success) {
const outcome = response.type;
this.sendSummarizationTelemetry(outcome, response.requestId, this.props.endpoint.model, mode, elapsedTime, undefined, response.reason);
this.logInfo(`Summarization request failed. ${response.type} ${response.reason}`, mode);
this.sendSummarizationTelemetry(outcome, response.requestId, this.props.endpoint.model, mode, elapsedTime, undefined, response.reason ?? response.type);
this.logInfo(`Summarization request failed. ${response.type} ${response.reason ?? response.type}`, mode);
if (response.type === ChatFetchResponseType.Canceled) {
throw new CancellationError();
}
Expand Down
Loading