ci: start the full app to verify signature on macOS#313013
Merged
deepak1556 merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
|
Base:
|
Collaborator
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Updates macOS CI signature verification to launch the signed VS Code app and confirm it can fully start, improving confidence that AMFI/entitlements issues won’t kill required processes at runtime.
Changes:
- Replace
--export-default-configurationwith a full app startup using--prof-append-timersas a readiness signal. - Add a bounded wait loop that fails the job if startup timers are not written (likely indicating AMFI termination).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml | Starts the signed app in CI and waits for --prof-append-timers output to validate startup. |
| build/azure-pipelines/darwin/product-build-darwin-universal.yml | Applies the same “start app + wait for timers file” verification in the universal build pipeline. |
deepak1556
force-pushed
the
robo/improve_verify_signature_check_macos
branch
2 times, most recently
from
dd918cb to
fbff653
Compare
deepak1556
force-pushed
the
robo/improve_verify_signature_check_macos
branch
from
fbff653 to
4c1407e
Compare
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
dmitrivMS
approved these changes
Apr 29, 2026
dpearson2699
pushed a commit
to dpearson2699/vscode
that referenced
this pull request
Apr 29, 2026
* ci: start the full app to verify signature on macOS * chore: bump timeout for x64 on rosetta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #312734 (comment)
Use
--prof-append-timersto start the full workbench that gives better conformance to all the required processes launching on the signed application.Also removed the
export-default-configurationwhich seems like a no-op today cc @roblourens