Skip to content

Update to chat status dashboard contributed sections#315134

Merged
pwang347 merged 10 commits into
mainfrom
pawang/chatStatusBarChanges
May 13, 2026
Merged

Update to chat status dashboard contributed sections#315134
pwang347 merged 10 commits into
mainfrom
pawang/chatStatusBarChanges

Conversation

@pwang347
Copy link
Copy Markdown
Member

@pwang347 pwang347 commented May 7, 2026

image image

Fixes #314794

Disable session sync from agent window

Copilot AI review requested due to automatic review settings May 7, 2026 23:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Chat Status “dashboard” UI to flatten contributed sections into a single, always-expanded header row with an info-icon hover, and aligns the embedded dashboard styling used in the Agents window account panel.

Changes:

  • Replace contributed-section collapsible headers with a single non-collapsible row and an info-icon hover for help/link content.
  • Render contributed detail inline in the header row (with new CSS to truncate/align it).
  • Update Agents window account panel CSS to match the new contributed-section layout and class names.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/chatStatus/media/chatStatus.css Adds styling for the new contributed info icon and inline detail text.
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts Flattens contributed sections into non-collapsible rows and adds info-icon hover content.
src/vs/sessions/contrib/accountMenu/browser/media/accountTitleBarWidget.css Adjusts embedded dashboard styling in the Sessions account panel for the new contributed layout.

Copilot's findings

Comments suppressed due to low confidence (2)

src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts:396

  • The hover content is created as new MarkdownString('', { isTrusted: true }) and then builds a markdown link via string interpolation (appendMarkdown(...(${headerLink}))). Since headerLink comes from ChatStatusEntry.label.link (potentially extension-provided), this allows markdown injection (e.g. ) to break out) and also unnecessarily enables trusted markdown (command links). Use MarkdownString.appendLink(...) (which escapes) and avoid isTrusted: true (or restrict trust to specific enabled commands if needed).
				this._store.add(this.hoverService.setupDelayedHover(infoIcon, () => {
					const hoverContent = new MarkdownString('', { isTrusted: true });
					if (linkDescription) {
						hoverContent.appendText(linkDescription);
					}
					if (headerLink) {
						if (linkDescription) {
							hoverContent.appendText(' ');
						}
						hoverContent.appendMarkdown(`[${localize('learnMore', "Learn More")}](${headerLink})`);
					}
					return { content: hoverContent };

src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts:397

  • The info icon is a plain <span> that only exposes its content via mouse hover, which is not keyboard/screen-reader accessible. Consider using a <button> (or at least tabIndex=0 + aria-label) and enabling keyboard hover events (e.g. setupKeyboardEvents: true) so users can focus the icon to read the help text.
			if (linkDescription || headerLink) {
				const infoIcon = header.appendChild($('span.contributed-info-icon'));
				infoIcon.classList.add(...ThemeIcon.asClassNameArray(Codicon.info));

				this._store.add(this.hoverService.setupDelayedHover(infoIcon, () => {
					const hoverContent = new MarkdownString('', { isTrusted: true });
					if (linkDescription) {
						hoverContent.appendText(linkDescription);
					}
					if (headerLink) {
						if (linkDescription) {
							hoverContent.appendText(' ');
						}
						hoverContent.appendMarkdown(`[${localize('learnMore', "Learn More")}](${headerLink})`);
					}
					return { content: hoverContent };
				}));
  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Copy link
Copy Markdown

@Montiwa11 Montiwa11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Montiwa11

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Base: c302942e Current: 6948a41b

No screenshot changes.

@pwang347 pwang347 changed the title Update to chat status dashboard Update to chat status dashboard contributed sections May 13, 2026
@pwang347 pwang347 marked this pull request as ready for review May 13, 2026 00:55
@pwang347 pwang347 enabled auto-merge (squash) May 13, 2026 00:55
@pwang347 pwang347 merged commit d2ce926 into main May 13, 2026
40 of 41 checks passed
@pwang347 pwang347 deleted the pawang/chatStatusBarChanges branch May 13, 2026 02:31
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish design for session sync and indexing in status menu

4 participants