Update to chat status dashboard contributed sections#315134
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Chat Status “dashboard” UI to flatten contributed sections into a single, always-expanded header row with an info-icon hover, and aligns the embedded dashboard styling used in the Agents window account panel.
Changes:
- Replace contributed-section collapsible headers with a single non-collapsible row and an info-icon hover for help/link content.
- Render contributed
detailinline in the header row (with new CSS to truncate/align it). - Update Agents window account panel CSS to match the new contributed-section layout and class names.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatStatus/media/chatStatus.css | Adds styling for the new contributed info icon and inline detail text. |
| src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts | Flattens contributed sections into non-collapsible rows and adds info-icon hover content. |
| src/vs/sessions/contrib/accountMenu/browser/media/accountTitleBarWidget.css | Adjusts embedded dashboard styling in the Sessions account panel for the new contributed layout. |
Copilot's findings
Comments suppressed due to low confidence (2)
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts:396
- The hover content is created as
new MarkdownString('', { isTrusted: true })and then builds a markdown link via string interpolation (appendMarkdown(...(${headerLink}))). SinceheaderLinkcomes fromChatStatusEntry.label.link(potentially extension-provided), this allows markdown injection (e.g.)to break out) and also unnecessarily enables trusted markdown (command links). UseMarkdownString.appendLink(...)(which escapes) and avoidisTrusted: true(or restrict trust to specific enabled commands if needed).
this._store.add(this.hoverService.setupDelayedHover(infoIcon, () => {
const hoverContent = new MarkdownString('', { isTrusted: true });
if (linkDescription) {
hoverContent.appendText(linkDescription);
}
if (headerLink) {
if (linkDescription) {
hoverContent.appendText(' ');
}
hoverContent.appendMarkdown(`[${localize('learnMore', "Learn More")}](${headerLink})`);
}
return { content: hoverContent };
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts:397
- The info icon is a plain
<span>that only exposes its content via mouse hover, which is not keyboard/screen-reader accessible. Consider using a<button>(or at leasttabIndex=0+aria-label) and enabling keyboard hover events (e.g.setupKeyboardEvents: true) so users can focus the icon to read the help text.
if (linkDescription || headerLink) {
const infoIcon = header.appendChild($('span.contributed-info-icon'));
infoIcon.classList.add(...ThemeIcon.asClassNameArray(Codicon.info));
this._store.add(this.hoverService.setupDelayedHover(infoIcon, () => {
const hoverContent = new MarkdownString('', { isTrusted: true });
if (linkDescription) {
hoverContent.appendText(linkDescription);
}
if (headerLink) {
if (linkDescription) {
hoverContent.appendText(' ');
}
hoverContent.appendMarkdown(`[${localize('learnMore', "Learn More")}](${headerLink})`);
}
return { content: hoverContent };
}));
- Files reviewed: 3/3 changed files
- Comments generated: 2
Contributor
|
Base:
|
dmitrivMS
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314794
Disable session sync from agent window