Skip to content

Clear details on sign out#315170

Merged
pwang347 merged 5 commits into
mainfrom
pawang/clearOnSignOut
May 8, 2026
Merged

Clear details on sign out#315170
pwang347 merged 5 commits into
mainfrom
pawang/clearOnSignOut

Conversation

@pwang347
Copy link
Copy Markdown
Member

@pwang347 pwang347 commented May 8, 2026

Fixes #314436

Copilot AI review requested due to automatic review settings May 8, 2026 04:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Copilot extension’s chat input quota/rate-limit notification logic to clear state and dismiss notifications when the user’s authentication state changes (intended to avoid showing stale quota details after sign-out).

Changes:

  • Adds an early-auth guard in _update() to clear shown-threshold caches and hide any active notification when the user is considered signed out.
  • Resets internal “exhausted notification” state when authentication is missing.
Show a summary per file
File Description
extensions/copilot/src/extension/chatInputNotification/vscode-node/chatInputNotification.contribution.ts Clears thresholds and hides chat input notifications on auth/session loss to avoid stale quota/rate-limit UI after sign-out.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Base: 67279f79 Current: ba88b002

No screenshot changes.

@pwang347 pwang347 marked this pull request as ready for review May 8, 2026 04:35
@pwang347 pwang347 enabled auto-merge (squash) May 8, 2026 04:35
@pwang347 pwang347 merged commit 89bab60 into main May 8, 2026
26 checks passed
@pwang347 pwang347 deleted the pawang/clearOnSignOut branch May 8, 2026 04:50
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monthly limit warning persisted if signed out

3 participants