Fix build break in chatInputNotificationService announce#315360
Merged
Conversation
vritant24
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a TypeScript build break in the chat input notification ARIA announcement path by ensuring IChatInputNotification.message (string | IMarkdownString) is coerced to a string before being used to build the “last announced” signature and passed to aria.status(...).
Changes:
- Convert
active.messageto astring(using.valueforIMarkdownString) before constructing the signature. - Use the coerced message string when building the announced text for
aria.status(...).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputNotificationService.ts | Coerces notification message to a string for ARIA announcement/signature to fix type-checking failure. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+171
to
178
| const message = typeof active.message === 'string' ? active.message : active.message.value; | ||
| const signature = `${active.id}\u0000${message}\u0000${active.description ?? ''}`; | ||
| if (signature === this._lastAnnouncedSignature) { | ||
| return; | ||
| } | ||
| this._lastAnnouncedSignature = signature; | ||
| const text = active.description ? `${active.message}. ${active.description}` : active.message; | ||
| const text = active.description ? `${message}. ${active.description}` : message; | ||
| status(text); |
Contributor
Author
There was a problem hiding this comment.
Will open a separate PR with the follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IChatInputNotification.messageis typedstring | IMarkdownString, but the new ARIA-announce code in #313787 fed it directly intoaria.status(...)and a template literal, which requirestring. The internal Azure DevOps build broke immediately after the merge with:Fix: coerce
messageto a string by reading.valuewhen it's anIMarkdownStringbefore building the signature and the announced text.Why CI didn't catch it (semantic merge conflict)
IChatInputNotification.messagewas still typedstring. The new code type-checked.messagetostring | IMarkdownString.mainwithout being rebased and without re-running CI on the merged tree. The post-merge Azure pipeline (build 437556) was the first job to compile the merge commit, so it surfaced the error..github/workflows/pr.yml(and the otherpr-*.ymlworkflows) only trigger onpull_request:. There is nomerge_group:trigger and no required-up-to-date branch protection, so GitHub never recompiles the merge commit before/after merging. Suggest enabling either:main+ addmerge_group:to the gating workflows, orBoth require repo-admin settings, so I haven't changed YAML here — happy to follow up with a workflow PR once a direction is picked.
Verification
Core - Typecheckwatch task:Finished compilation with 0 errors.