Bump copilot cli npm to 1.0.47#316294
Closed
DonJayamanne wants to merge 18 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the bundled @github/copilot CLI SDK from 1.0.39 to 1.0.47 and updates supporting test/postinstall logic to reflect the new SDK contents (new native binaries, removal of the legacy win32.node).
Changes:
- Update
@github/copilotdependency to^1.0.47inpackage.jsonandpackage-lock.json. - Expand the
knownBinariesallowlist in the SDK upgrade test to cover the newnative/runtime/*,native/win32/*,foundry-local-sdk,pvrecorder, andmxc-binfiles; drop legacywin32.nodeentries. - Drop
win32.nodefrom the prebuilds copy filter inpostinstall.ts.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/package.json | Bumps @github/copilot to ^1.0.47. |
| extensions/copilot/package-lock.json | Lockfile updates for SDK 1.0.47 and its platform packages. |
| extensions/copilot/script/postinstall.ts | Stops copying legacy win32.node from prebuilds; comment is out of sync. |
| extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/test/copilotCLISDKUpgrade.spec.ts | Updates the known-binaries allowlist to match the SDK 1.0.47 file layout. |
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Language not supported
- Files reviewed: 3/4 changed files
- Comments generated: 1
dmitrivMS
previously approved these changes
May 13, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… logic in postinstall script
rzhao271
requested changes
May 14, 2026
Collaborator
rzhao271
left a comment
rzhao271
left a comment
There was a problem hiding this comment.
Should the root directory's github/copilot also be updated?
Contributor
Author
@rzhao271 that will be updated later, thats not related to Chat extension. |
Yoyokrazy
previously approved these changes
May 14, 2026
rzhao271
previously approved these changes
May 14, 2026
anthonykim1
reviewed
May 14, 2026
| path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'windows', 'amd64', 'pv_recorder.node'), | ||
| path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'windows', 'arm64', 'pv_recorder.node'), | ||
| // mxc-bin (Windows sandbox + WSL helpers used by the SDK's command execution). | ||
| path.join('mxc-bin', 'arm64', 'lxc-exec'), |
Contributor
There was a problem hiding this comment.
I think mxc sandboxing feature was behind experimental, but maybe we should have comment saying to include this once its necessary/ no longer behind experiment.
Contributor
|
Got it passing for now: #316566 + slack thread for context |
…es and updating glob patterns to exclude them from modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.