Update Copilot CLI to 1.0.48#316566
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… logic in postinstall script
There was a problem hiding this comment.
Pull request overview
Bumps the @github/copilot CLI SDK to ^1.0.48 and updates VS Code's packaging/postinstall plumbing to handle the new set of native binaries (sdk-side runtime.node / icu-native.node / win32-native.node, plus newly vendored foundry-local-sdk, pvrecorder, and mxc-bin payloads). The SDK-upgrade test is extended to enumerate the new binaries so unexpected additions are still caught.
Changes:
- Loosen
@github/copilotdependency from a pinned1.0.48to a caret range^1.0.48(in bothpackage.jsonandpackage-lock.json). - Update
postinstallfilter,.vscodeignore,.moduleignore, and the build-time prune helper so the new SDK prebuilds are copied/included or stripped per platform. - Extend the SDK-upgrade native-binary inventory test with the new expected files.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/package.json | Switches @github/copilot to a caret range. |
| extensions/copilot/package-lock.json | Lockfile mirror of the same range change. |
| extensions/copilot/script/postinstall.ts | Broadens the file filter to also copy *native.node and runtime.node from the SDK prebuilds. |
| extensions/copilot/.vscodeignore | Whitelists runtime.node, icu-native.node, and win32-native.node under sdk/prebuilds/* for the published extension. |
| build/.moduleignore | Strips newly vendored foundry-local-sdk, pvrecorder, and mxc-bin payloads from the built product. |
| build/lib/copilot.ts | Adds pruneNonTargetCopilotSdkPrebuilds to remove non-target platform prebuilds before shipping. |
| extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/test/copilotCLISDKUpgrade.spec.ts | Extends the known-binaries inventory; entries for the new vendored bindings are duplicated in two blocks. |
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/test/copilotCLISDKUpgrade.spec.ts:132
- These foundry-local-sdk (lines 102–105), pvrecorder (lines 107–111), and mxc-bin (lines 113–132) entries are duplicated later in the same set at lines 153–184 of this file. Because
knownBinariesis aSet, the duplicates are silently de-duplicated and the test still passes, but the duplication is confusing and easy to fall out of sync (e.g. updating one block but not the other when the SDK adds/removes a file). One of the two blocks should be removed.
// foundry-local-sdk vendored native bindings.
path.join('foundry-local-sdk', 'node_modules', 'foundry-local-sdk', 'prebuilds', 'darwin-arm64', 'foundry_local_napi.node'),
path.join('foundry-local-sdk', 'node_modules', 'foundry-local-sdk', 'prebuilds', 'linux-x64', 'foundry_local_napi.node'),
path.join('foundry-local-sdk', 'node_modules', 'foundry-local-sdk', 'prebuilds', 'win32-arm64', 'foundry_local_napi.node'),
path.join('foundry-local-sdk', 'node_modules', 'foundry-local-sdk', 'prebuilds', 'win32-x64', 'foundry_local_napi.node'),
// pvrecorder vendored native bindings.
path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'linux', 'x86_64', 'pv_recorder.node'),
path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'mac', 'arm64', 'pv_recorder.node'),
path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'mac', 'x86_64', 'pv_recorder.node'),
path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'windows', 'amd64', 'pv_recorder.node'),
path.join('pvrecorder', 'node_modules', '@picovoice', 'pvrecorder-node', 'lib', 'windows', 'arm64', 'pv_recorder.node'),
// mxc-bin (Windows sandbox + WSL helpers used by the SDK's command execution).
path.join('mxc-bin', 'arm64', 'lxc-exec'),
path.join('mxc-bin', 'arm64', 'winhttp-proxy-shim.exe'),
path.join('mxc-bin', 'arm64', 'wslcsdk.dll'),
path.join('mxc-bin', 'arm64', 'wxc-exec.exe'),
path.join('mxc-bin', 'arm64', 'wxc-test-proxy.exe'),
path.join('mxc-bin', 'arm64', 'wxc-windows-sandbox-daemon.exe'),
path.join('mxc-bin', 'arm64', 'wxc-windows-sandbox-guest.exe'),
path.join('mxc-bin', 'arm64', '_manifest', 'spdx_2.2', 'bsi.cose'),
path.join('mxc-bin', 'arm64', '_manifest', 'spdx_2.2', 'manifest.cat'),
path.join('mxc-bin', 'arm64', '_manifest', 'spdx_2.2', 'manifest.spdx.cose'),
path.join('mxc-bin', 'x64', 'lxc-exec'),
path.join('mxc-bin', 'x64', 'winhttp-proxy-shim.exe'),
path.join('mxc-bin', 'x64', 'wslcsdk.dll'),
path.join('mxc-bin', 'x64', 'wxc-exec.exe'),
path.join('mxc-bin', 'x64', 'wxc-test-proxy.exe'),
path.join('mxc-bin', 'x64', 'wxc-windows-sandbox-daemon.exe'),
path.join('mxc-bin', 'x64', 'wxc-windows-sandbox-guest.exe'),
path.join('mxc-bin', 'x64', '_manifest', 'spdx_2.2', 'bsi.cose'),
path.join('mxc-bin', 'x64', '_manifest', 'spdx_2.2', 'manifest.cat'),
path.join('mxc-bin', 'x64', '_manifest', 'spdx_2.2', 'manifest.spdx.cose'),
- Files reviewed: 6/7 changed files
- Comments generated: 3
|
Instead of hand rolling signature removal for PE files, please consider using signtool and also make it central as part of vscode/build/gulpfile.vscode.ts Line 524 in 176a967 |
|
started #316948 |
* build: remove PE signature before patching via rcedit * build: also apply to reh
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|


Should supersede: #316294