Skip to content

build: remove PE signature before patching via rcedit#316948

Merged
anthonykim1 merged 2 commits into
anthonykim1/CopilotCli1048from
robo/cleanup_signature_wiring
May 18, 2026
Merged

build: remove PE signature before patching via rcedit#316948
anthonykim1 merged 2 commits into
anthonykim1/CopilotCli1048from
robo/cleanup_signature_wiring

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 commented May 18, 2026

Error: SignedCode::Sign returned error: 0x800700C1\r\n\tFor more information, please see https://aka.ms/badexeformat

@deepak1556 deepak1556 added this to the 1.122.0 milestone May 18, 2026
@deepak1556 deepak1556 self-assigned this May 18, 2026
@deepak1556
Copy link
Copy Markdown
Collaborator Author

deepak1556 commented May 18, 2026

@deepak1556 deepak1556 force-pushed the robo/cleanup_signature_wiring branch from b5e6378 to 9bc7017 Compare May 18, 2026 09:40
@deepak1556 deepak1556 force-pushed the robo/cleanup_signature_wiring branch from 9bc7017 to b575644 Compare May 18, 2026 10:38
@deepak1556 deepak1556 requested a review from anthonykim1 May 18, 2026 11:47
@deepak1556 deepak1556 marked this pull request as ready for review May 18, 2026 11:47
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/win32/steps/product-build-win32-compile.yml

@anthonykim1
Copy link
Copy Markdown
Contributor

Great, thank you!

/cc @DonJayamanne

@anthonykim1 anthonykim1 merged commit 082fe3d into anthonykim1/CopilotCli1048 May 18, 2026
18 checks passed
@anthonykim1 anthonykim1 deleted the robo/cleanup_signature_wiring branch May 18, 2026 16:02
DonJayamanne added a commit that referenced this pull request May 18, 2026
* Bump version

* Updates

* Updates

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* chore: update @github/copilot to version 1.0.48 and enhance file copy logic in postinstall script

* Updates

* updates

* Include other files

* udpates

* updates

* Also filter prebuilds one

* Prune non-target Copilot SDK prebuilds

* Try clean-up

* revert

* try with foundtry, pvrecorder,mxcbin

* try if excluding computer.node helps

* Try if stripping cli signatures would work

* Revert "try if excluding computer.node helps"

This reverts commit c51a9e7.

* Revert "try with foundtry, pvrecorder,mxcbin"

This reverts commit 4c98422.

* build: remove PE signature before patching via rcedit (#316948)

* build: remove PE signature before patching via rcedit

* build: also apply to reh

* Need to update properly

---------

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants