Disable walkthrough if ai features disabled on startup#318364
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures AI-specific onboarding and default layout behavior respect the chat.disableAIFeatures setting at startup, so new users don’t see AI-focused UI when AI features are disabled.
Changes:
- Skip showing the experimental onboarding overlay for new users when
chat.disableAIFeaturesis enabled. - Adjust the auxiliary bar default visibility so it is not forced open for new users when AI features are disabled.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/welcomeGettingStarted/browser/startupPage.ts | Gates the experimental onboarding overlay on chat.disableAIFeatures. |
| src/vs/workbench/browser/layout.ts | Prevents forcing auxiliary bar visibility for new users when AI features are disabled. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
rzhao271
requested changes
May 26, 2026
rzhao271
previously approved these changes
May 26, 2026
rzhao271
approved these changes
May 26, 2026
bhavyaus
reviewed
May 26, 2026
bhavyaus
requested changes
May 26, 2026
bhavyaus
approved these changes
May 26, 2026
cwebster-99
added
the
~release-cherry-pick
Contributor
|
This PR will be automatically cherry-picked to |
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces logic to ensure that AI-focused onboarding and UI elements are only shown to users when AI features are enabled and visible. The changes primarily impact the onboarding experience for new users and the display of the auxiliary bar in empty workspaces.
Key changes:
Onboarding and Welcome Experience:
chatEntitlementService.sentiment.hidden) and skips AI-focused onboarding for users where AI features are not available or visible.StartupPageRunnerContributionclass now injects theIChatEntitlementServicedependency to access AI feature visibility.IChatEntitlementServiceimport was added to support the above logic.Auxiliary Bar Visibility:
chat.disableAIFeaturesconfiguration, and hides the bar if so.LayoutStateModel.load() runs during early layout initialization — before any WorkbenchPhase. The ChatEntitlementContext (which sets the chatSetupHidden context key from chat.disableAIFeatures) is lazily created inside ChatEntitlementService and won't be resolved yet. So sentiment.hidden would always return false at that point, defeating the guard.