Clear timeouts/intervals on dispose in extensions#319125
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves lifecycle cleanup in the Copilot Chat extension by ensuring scheduled timers (timeouts/intervals) are cleared when related services are disposed, reducing the risk of background work continuing after deactivation.
Changes:
- Track and clear the inactivity survey timeout and usage debounce timeout in
SurveyService.dispose(). - Clear the active-thread monitoring interval in
ReviewServiceImpl.dispose(). - Add disposal cleanup for blocked-extension expiry timers in
BlockedExtensionService.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/survey/vscode/surveyServiceImpl.ts | Tracks timeout handles and clears them on service disposal. |
| extensions/copilot/src/platform/review/vscode/reviewServiceImpl.ts | Clears the review-thread monitoring interval during disposal. |
| extensions/copilot/src/platform/chat/common/blockedExtensionService.ts | Uses typed timeout handles and clears them during disposal. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 4
dmitrivMS
changed the title
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
benibenj
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.