Follow up on Copilot comments to a previous PR#319135
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to PR #319125 addressing review feedback on cleanup of timeouts/intervals and disposable handling in extensions.
Changes:
- PHP validation provider now cancels all pending
ThrottledDelayerinstances on dispose. - Survey service uses explicit
=== undefinedcheck before setting the debounce timeout. - Review service registers the comment controller with its
DisposableStorefor proper disposal.
Show a summary per file
| File | Description |
|---|---|
| extensions/php-language-features/src/features/validationProvider.ts | Cancel pending delayers and clear the map on dispose(). |
| extensions/copilot/src/platform/survey/vscode/surveyServiceImpl.ts | Use strict === undefined check for debounceTimeout. |
| extensions/copilot/src/platform/review/vscode/reviewServiceImpl.ts | Track the created CommentController in the _disposables store. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
aiday-mar
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on comments for #319125