Adding policy config to forceFirstExecutionInSandbox setting - #322462
Draft
dileepyavan wants to merge 5 commits into
Draft
Adding policy config to forceFirstExecutionInSandbox setting#322462dileepyavan wants to merge 5 commits into
dileepyavan wants to merge 5 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @anthonykim1Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an enterprise policy definition for the existing chat.agent.sandbox.forceFirstExecutionInSandbox setting so administrators can centrally manage it as part of the terminal chat/agent sandbox configuration.
Changes:
- Registers a new
policyblock forAgentSandboxForceFirstExecutionInSandbox. - Minor formatting/escaping adjustments in the configuration schema file (array bracket alignment; escaping markdown backticks in localized strings).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts | Adds a policy definition for forceFirstExecutionInSandbox and includes small formatting/string escaping tweaks. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
+611
to
+621
| policy: { | ||
| name: 'ChatAgentSandboxForceFirstExecutionInSandbox', | ||
| category: PolicyCategory.IntegratedTerminal, | ||
| minimumVersion: '1.126', | ||
| localization: { | ||
| description: { | ||
| key: 'agentSandbox.forceFirstExecutionInSandbox', | ||
| value: localize('agentSandbox.forceFirstExecutionInSandbox', "Controls whether agent mode terminal commands first run with the sandbox's configured restrictions before honoring a request for execution outside the sandbox or unrestricted network access. The user is prompted to approve the requested additional access only if that sandboxed command fails. This applies only when {0} is enabled.", `\`#${AgentSandboxSettingId.AgentSandboxEnabled}#\``), | ||
| } | ||
| } | ||
| } |
dileepyavan
marked this pull request as draft
June 22, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #321647