Fix hiding Update UI during active chat sessions - #322857
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
dmitrivMS
enabled auto-merge (squash)
June 25, 2026 00:46
dmitrivMS
added
the
install-update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workbench update-title-bar contribution so the Update title bar indicator is suppressed whenever a chat request is in progress, preventing the indicator from remaining visible after chat activity begins (aligning the behavior with other “hide during activity” cases like debug mode).
Changes:
- Introduces a dedicated context key (
updateTitleBarChatRequestInProgress) that tracksIChatService.requestInProgressObsviaautorun. - Updates menu
whenclauses to require no chat request in progress before rendering the update title bar action (including any additional registered placement). - Simplifies actionable-state handling by no longer delaying
updateTitleBarcontext changes until chat becomes idle.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts | Adds a chat-in-progress context key and uses it in when clauses so the Update title bar UI hides during in-flight chat requests. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
roblourens
approved these changes
Jun 25, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312330
Before this change Update button would be hidden if update state changed during an active chat session, but it would not hide again if a new chat is started after Update button is shown.
Now Update button will hide during active chat sessions (similar to how it works with debug sessions already).