agents: new session action group toolbar f3219f4a#322920
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @sandy081Matched files:
@lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated group-header toolbar action in the Agents sessions list to start a “New Session” that will automatically join the selected user-created group, backed by new sessions-management signaling to clear the intent when the composer draft is discarded.
Changes:
- Documented the new
SessionGroupToolbarmenu entry for group header toolbars. - Added
ISessionsManagementService.onDidDiscardNewSessionand implemented it inSessionsManagementService. - Implemented pending/in-flight “new session → group” binding in
SessionGroupsService, wired via send/start/replace/discard lifecycle events, and added unit tests for the grouping behavior. - Added a new
New Sessionaction to the group header toolbar (SessionGroupToolbarMenuId).
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/SESSIONS_LIST.md | Documents the new group header toolbar menu and intended behavior. |
| src/vs/sessions/services/sessions/test/browser/sessionNavigation.test.ts | Updates mock ISessionsManagementService to include the new discard event. |
| src/vs/sessions/services/sessions/test/browser/sessionGroupsService.test.ts | Adds tests validating pending-group intent binding across send/replace/start and clearing on discard/delete. |
| src/vs/sessions/services/sessions/common/sessionsManagement.ts | Extends the sessions management interface with onDidDiscardNewSession. |
| src/vs/sessions/services/sessions/browser/sessionsManagementService.ts | Fires onDidDiscardNewSession when discarding the in-progress draft. |
| src/vs/sessions/services/sessions/browser/sessionGroupsService.ts | Tracks pending intent + in-flight sends to bind started sessions into groups reliably. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts | Adds the group-header “New Session” toolbar action and orders rename/delete after it. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 2
Reword the onDidDiscardNewSession JSDoc to note that sendRequest into an existing session also discards the pending draft, while sendNewChatRequest clears it without firing the event. Add unit tests asserting the event fires on discardNewSession and does not fire on sendNewChatRequest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hediet
previously approved these changes
Jun 25, 2026
…tion-group-toolbar-f3219f4a # Conflicts: # src/vs/sessions/services/sessions/browser/sessionGroupsService.ts # src/vs/sessions/services/sessions/test/browser/sessionGroupsService.test.ts
osortega
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322896
Created from
agents/new-session-action-group-toolbar-f3219f4atargetingmain.