Model picker: clearer Restricted Mode copy and suppress search - #323201
Merged
Conversation
Reword the Restricted Mode model picker so the button, header, and action read as a coherent set, and hide the search field in the unavailable states (only a header + Trust/Sign In action are shown, so there is nothing to search). - Button: "Pick Model" -> "Models" - Header: "Models Unavailable in Restricted Mode" -> "Models unavailable while in Restricted mode" - Action: "Trust Workspace..." -> "Trust Workspace to enable models..." - Suppress the dropdown search filter while restricted / setup-required Addresses feedback from https://vscodeteam.slack.com/archives/C1C2M1KEZ/p1782496657211199 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
UX follow-up to the chat model picker’s Restricted Mode and setup-required states: updates the displayed copy to more clearly explain why models are unavailable, and hides the search/filter UI when there’s nothing meaningful to search.
Changes:
- Updates Restricted Mode header/action/hover copy (e.g. “Models unavailable while in Restricted mode”, “Trust Workspace to enable models...”).
- Suppresses the model-picker search/filter row when the picker is in Restricted Mode or setup-required state.
- Updates unit test expectations for the new Restricted Mode header label.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Updates test assertion to match the new Restricted Mode header text. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts | Updates hover copy for Restricted Mode / setup-required messaging. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Updates Restricted Mode header/action copy and hides the filter/search UI in unavailable states; updates placeholder label. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
roblourens
previously approved these changes
Jun 26, 2026
Dmitriy Vasyura (dmitrivMS)
requested changes
Jun 26, 2026
Dmitriy Vasyura (dmitrivMS)
left a comment
Dmitriy Vasyura (dmitrivMS)
left a comment
Collaborator
There was a problem hiding this comment.
Copilot comments on a11y
Address PR review: the visible picker label is now 'Models', but the hover tooltip and aria-labels still read 'Pick Model'. Name the control 'Models' in both (reusing the shared label key) so screen-reader and hover copy match the visible UI. Reword the Restricted Mode suffixes to avoid a 'Models • Models' / 'Models, models' stutter. Retire the now-unused 'Pick Model' string and refresh stale comments referencing it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Jun 26, 2026
Alexandru Dima (alexdima)
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX follow-up to #323183: clearer Restricted Mode model picker copy, and suppress the search field in the unavailable states (nothing to search there).
Addresses feedback from https://vscodeteam.slack.com/archives/C1C2M1KEZ/p1782496657211199
Relates to #322564.